[v4,12/12] Whitespace adjustment guideline

Submitted by Christophe de Dinechin on Feb. 15, 2018, 4:06 p.m.

Details

Message ID 20180215160625.75406-13-christophe@dinechin.org
State New
Headers show
Series "Updates to the style guide" ( rev: 3 ) in Spice

Not browsing as part of any series.

Commit Message

Christophe de Dinechin Feb. 15, 2018, 4:06 p.m.
From: Christophe de Dinechin <dinechin@redhat.com>

Change since v3:
- This particular aspect is controversial, so it was put in a separate patch.

Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
---
 docs/spice_style.txt | 2 ++
 1 file changed, 2 insertions(+)

Patch hide | download patch | download mbox

diff --git a/docs/spice_style.txt b/docs/spice_style.txt
index 13bd3809..0cbd3570 100644
--- a/docs/spice_style.txt
+++ b/docs/spice_style.txt
@@ -559,3 +559,5 @@  Compilation
 The source code should compile without warnings on all variants of GCC and clang available.
 A patch may be rejected if it introduces new warnings.
 Warnings that appear over time due to improvements in compilers should be fixed in dedicated patches. A patch should not mix warning fixes and other changes.
+
+Any patch may adjust whitespace (e.g. eliminate trailing whitespace). Whitespace adjustments do not require specific patches

Comments

On Thu, Feb 15, 2018 at 05:06:25PM +0100, Christophe de Dinechin wrote:
> From: Christophe de Dinechin <dinechin@redhat.com>
> 
> Change since v3:
> - This particular aspect is controversial, so it was put in a separate patch.

This has been nack'ed by multiple people already, please don't resend it
unchanged.

Christophe

> 
> Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
> ---
>  docs/spice_style.txt | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/docs/spice_style.txt b/docs/spice_style.txt
> index 13bd3809..0cbd3570 100644
> --- a/docs/spice_style.txt
> +++ b/docs/spice_style.txt
> @@ -559,3 +559,5 @@ Compilation
>  The source code should compile without warnings on all variants of GCC and clang available.
>  A patch may be rejected if it introduces new warnings.
>  Warnings that appear over time due to improvements in compilers should be fixed in dedicated patches. A patch should not mix warning fixes and other changes.
> +
> +Any patch may adjust whitespace (e.g. eliminate trailing whitespace). Whitespace adjustments do not require specific patches
> -- 
> 2.13.5 (Apple Git-94)
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel