[RFC,1/3] intel-gpu-top: Rename to intel-legacy-top

Submitted by Tvrtko Ursulin on Feb. 14, 2018, 6:52 p.m.

Details

Message ID 20180214185207.8111-2-tvrtko.ursulin@linux.intel.com
State New
Headers show
Series "New intel-gpu-top" ( rev: 1 ) in IGT (deprecated)

Not browsing as part of any series.

Commit Message

Tvrtko Ursulin Feb. 14, 2018, 6:52 p.m.
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 tools/.gitignore                              | 2 +-
 tools/Makefile.sources                        | 2 +-
 tools/{intel_gpu_top.c => intel_legacy_top.c} | 0
 tools/meson.build                             | 2 +-
 4 files changed, 3 insertions(+), 3 deletions(-)
 rename tools/{intel_gpu_top.c => intel_legacy_top.c} (100%)

Patch hide | download patch | download mbox

diff --git a/tools/.gitignore b/tools/.gitignore
index 2de665a36688..19a1f7cb8e50 100644
--- a/tools/.gitignore
+++ b/tools/.gitignore
@@ -17,7 +17,7 @@  intel_framebuffer_dump
 intel_gem_info
 intel_gpu_frequency
 intel_gpu_time
-intel_gpu_top
+intel_legacy_top
 intel_gtt
 intel_guc_logger
 intel_gvtg_test
diff --git a/tools/Makefile.sources b/tools/Makefile.sources
index abd23a0f4628..9699b7d2f737 100644
--- a/tools/Makefile.sources
+++ b/tools/Makefile.sources
@@ -17,7 +17,7 @@  tools_prog_lists =		\
 	intel_gpu_frequency	\
 	intel_firmware_decode	\
 	intel_gpu_time		\
-	intel_gpu_top		\
+	intel_legacy_top	\
 	intel_gtt		\
 	intel_guc_logger        \
 	intel_infoframes	\
diff --git a/tools/intel_gpu_top.c b/tools/intel_legacy_top.c
similarity index 100%
rename from tools/intel_gpu_top.c
rename to tools/intel_legacy_top.c
diff --git a/tools/meson.build b/tools/meson.build
index a96735c2244d..ebce4e305d00 100644
--- a/tools/meson.build
+++ b/tools/meson.build
@@ -23,7 +23,7 @@  tools_progs = [
 	'intel_gpu_frequency',
 	'intel_firmware_decode',
 	'intel_gpu_time',
-	'intel_gpu_top',
+	'intel_legacy_top',
 	'intel_gtt',
 	'intel_guc_logger',
 	'intel_infoframes',

Comments

Quoting Petri Latvala (2018-02-15 09:10:45)
> On Wed, Feb 14, 2018 at 06:52:05PM +0000, Tvrtko Ursulin wrote:
> > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > 
> > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > ---
> >  tools/.gitignore                              | 2 +-
> >  tools/Makefile.sources                        | 2 +-
> >  tools/{intel_gpu_top.c => intel_legacy_top.c} | 0
> >  tools/meson.build                             | 2 +-
> >  4 files changed, 3 insertions(+), 3 deletions(-)
> >  rename tools/{intel_gpu_top.c => intel_legacy_top.c} (100%)
> 
> 
> If the old tool is to be kept, 

No. The old tool should be removed as it is a machine killer.
-Chris
On 15/02/2018 09:10, Petri Latvala wrote:
> On Wed, Feb 14, 2018 at 06:52:05PM +0000, Tvrtko Ursulin wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>> ---
>>   tools/.gitignore                              | 2 +-
>>   tools/Makefile.sources                        | 2 +-
>>   tools/{intel_gpu_top.c => intel_legacy_top.c} | 0
>>   tools/meson.build                             | 2 +-
>>   4 files changed, 3 insertions(+), 3 deletions(-)
>>   rename tools/{intel_gpu_top.c => intel_legacy_top.c} (100%)
> 
> 
> If the old tool is to be kept, the name intel_legacy_top doesn't quite
> capture what it does. A more important topic though is whether it
> should be kept at all. What are the features in the old tool that your
> rewrite doesn't have?

It's a bit different in target audience and capabilities I think.

The current one exposes what OA is, I assume at least, able to provide 
today in a safe way. The new tool doesn't do any of that but just 
provides basic, more end-user friendly, engine busyness and related stats.

It may be that when considering gpu-top work, intel-gpu-top rewrite 
hasn't even got a place. Or it might have as a minimal, easy to use and 
simple tool. TBD.

On 15/02/2018 09:17, Chris Wilson wrote:
 > Quoting Petri Latvala (2018-02-15 09:10:45)
 >>
 >> If the old tool is to be kept,
 >
 > No. The old tool should be removed as it is a machine killer.

And it is not up to date with current hardware so no complaints from me.

Regards,

Tvrtko
Quoting Tvrtko Ursulin (2018-02-15 09:57:45)
> 
> On 15/02/2018 09:10, Petri Latvala wrote:
> > On Wed, Feb 14, 2018 at 06:52:05PM +0000, Tvrtko Ursulin wrote:
> >> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> >>
> >> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> >> ---
> >>   tools/.gitignore                              | 2 +-
> >>   tools/Makefile.sources                        | 2 +-
> >>   tools/{intel_gpu_top.c => intel_legacy_top.c} | 0
> >>   tools/meson.build                             | 2 +-
> >>   4 files changed, 3 insertions(+), 3 deletions(-)
> >>   rename tools/{intel_gpu_top.c => intel_legacy_top.c} (100%)
> > 
> > 
> > If the old tool is to be kept, the name intel_legacy_top doesn't quite
> > capture what it does. A more important topic though is whether it
> > should be kept at all. What are the features in the old tool that your
> > rewrite doesn't have?
> 
> It's a bit different in target audience and capabilities I think.
> 
> The current one exposes what OA is, I assume at least, able to provide 
> today in a safe way. The new tool doesn't do any of that but just 
> provides basic, more end-user friendly, engine busyness and related stats.
> 
> It may be that when considering gpu-top work, intel-gpu-top rewrite 
> hasn't even got a place. Or it might have as a minimal, easy to use and 
> simple tool. TBD.

I liken it to classic "top", even when we have graphical system
monitors, for a quick assay of what's running, top is unbeatable.
I think each tool has its use. There may be future refactoring to a
single tool with different interfaces, but for now it looks to be a nice
little demonstration vehicle with some practical value.
-Chris