[2/3] anv/gen10: Remove warning message.

Submitted by Rafael Antognolli on Feb. 13, 2018, 9:51 p.m.

Details

Message ID 20180213215155.12946-2-rafael.antognolli@intel.com
State New
Headers show
Series "Series without cover letter" ( rev: 1 ) in Mesa

Not browsing as part of any series.

Commit Message

Rafael Antognolli Feb. 13, 2018, 9:51 p.m.
Gen10 seems pretty stable so far, remove "alpha support" message.

Signed-off-by: Rafael Antognolli <rafael.antognolli@intel.com>
Cc: Jason Ekstrand <jason@jlekstrand.net>
Cc: "18.0" mesa-stable@lists.freedesktop.org
---
 src/intel/vulkan/anv_device.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

Patch hide | download patch | download mbox

diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
index 86c1bdc1d51..7390fc3600b 100644
--- a/src/intel/vulkan/anv_device.c
+++ b/src/intel/vulkan/anv_device.c
@@ -312,11 +312,9 @@  anv_physical_device_init(struct anv_physical_device *device,
       intel_logw("Ivy Bridge Vulkan support is incomplete");
    } else if (device->info.gen == 7 && device->info.is_baytrail) {
       intel_logw("Bay Trail Vulkan support is incomplete");
-   } else if (device->info.gen >= 8 && device->info.gen <= 9) {
-      /* Broadwell, Cherryview, Skylake, Broxton, Kabylake, Coffelake is as
-       * fully supported as anything */
-   } else if (device->info.gen == 10) {
-      intel_logw("Cannonlake Vulkan support is alpha");
+   } else if (device->info.gen >= 8 && device->info.gen <= 10) {
+      /* Broadwell, Cherryview, Skylake, Broxton, Kabylake, Coffelake,
+       * Cannonlake is as fully supported as anything */
    } else {
       result = vk_errorf(device->instance, device,
                          VK_ERROR_INCOMPATIBLE_DRIVER,

Comments

Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>

On Tue, Feb 13, 2018 at 1:51 PM, Rafael Antognolli <
rafael.antognolli@intel.com> wrote:

> Gen10 seems pretty stable so far, remove "alpha support" message.
>
> Signed-off-by: Rafael Antognolli <rafael.antognolli@intel.com>
> Cc: Jason Ekstrand <jason@jlekstrand.net>
> Cc: "18.0" mesa-stable@lists.freedesktop.org
> ---
>  src/intel/vulkan/anv_device.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
> index 86c1bdc1d51..7390fc3600b 100644
> --- a/src/intel/vulkan/anv_device.c
> +++ b/src/intel/vulkan/anv_device.c
> @@ -312,11 +312,9 @@ anv_physical_device_init(struct anv_physical_device
> *device,
>        intel_logw("Ivy Bridge Vulkan support is incomplete");
>     } else if (device->info.gen == 7 && device->info.is_baytrail) {
>        intel_logw("Bay Trail Vulkan support is incomplete");
> -   } else if (device->info.gen >= 8 && device->info.gen <= 9) {
> -      /* Broadwell, Cherryview, Skylake, Broxton, Kabylake, Coffelake is
> as
> -       * fully supported as anything */
> -   } else if (device->info.gen == 10) {
> -      intel_logw("Cannonlake Vulkan support is alpha");
> +   } else if (device->info.gen >= 8 && device->info.gen <= 10) {
> +      /* Broadwell, Cherryview, Skylake, Broxton, Kabylake, Coffelake,
> +       * Cannonlake is as fully supported as anything */
>     } else {
>        result = vk_errorf(device->instance, device,
>                           VK_ERROR_INCOMPATIBLE_DRIVER,
> --
> 2.14.3
>
>
On Tuesday, February 13, 2018 1:51:54 PM PST Rafael Antognolli wrote:
> Gen10 seems pretty stable so far, remove "alpha support" message.
> 
> Signed-off-by: Rafael Antognolli <rafael.antognolli@intel.com>
> Cc: Jason Ekstrand <jason@jlekstrand.net>
> Cc: "18.0" mesa-stable@lists.freedesktop.org
> ---
>  src/intel/vulkan/anv_device.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
> index 86c1bdc1d51..7390fc3600b 100644
> --- a/src/intel/vulkan/anv_device.c
> +++ b/src/intel/vulkan/anv_device.c
> @@ -312,11 +312,9 @@ anv_physical_device_init(struct anv_physical_device *device,
>        intel_logw("Ivy Bridge Vulkan support is incomplete");
>     } else if (device->info.gen == 7 && device->info.is_baytrail) {
>        intel_logw("Bay Trail Vulkan support is incomplete");
> -   } else if (device->info.gen >= 8 && device->info.gen <= 9) {
> -      /* Broadwell, Cherryview, Skylake, Broxton, Kabylake, Coffelake is as
> -       * fully supported as anything */
> -   } else if (device->info.gen == 10) {
> -      intel_logw("Cannonlake Vulkan support is alpha");
> +   } else if (device->info.gen >= 8 && device->info.gen <= 10) {
> +      /* Broadwell, Cherryview, Skylake, Broxton, Kabylake, Coffelake,
> +       * Cannonlake is as fully supported as anything */

Getting a pretty huge list of codenames here, and Coffee was misspelled.
I'd just change it to /* Gen8-10 fully supported */ or some such.

Series is:
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>

>     } else {
>        result = vk_errorf(device->instance, device,
>                           VK_ERROR_INCOMPATIBLE_DRIVER,
>