[v2,6/8] radeon/uvd:add uvd hevc enc files in Makefile list

Submitted by Zhu, James on Feb. 6, 2018, 8:05 p.m.

Details

Message ID 1517947545-12416-7-git-send-email-James.Zhu@amd.com
State New
Headers show
Series "The 2nd version for UVD HEVC encode" ( rev: 2 1 ) in Mesa

Not browsing as part of any series.

Commit Message

Zhu, James Feb. 6, 2018, 8:05 p.m.
Signed-off-by: James Zhu <James.Zhu@amd.com>
---
 src/gallium/drivers/radeon/Makefile.sources | 3 +++
 1 file changed, 3 insertions(+)

Patch hide | download patch | download mbox

diff --git a/src/gallium/drivers/radeon/Makefile.sources b/src/gallium/drivers/radeon/Makefile.sources
index b756d72..f8ee860 100644
--- a/src/gallium/drivers/radeon/Makefile.sources
+++ b/src/gallium/drivers/radeon/Makefile.sources
@@ -15,6 +15,9 @@  C_SOURCES := \
 	radeon_vcn_enc_1_2.c \
 	radeon_vcn_enc.c \
 	radeon_vcn_enc.h \
+	radeon_uvd_enc_1_1.c \
+	radeon_uvd_enc.c \
+	radeon_uvd_enc.h \
 	radeon_vce_40_2_2.c \
 	radeon_vce_50.c \
 	radeon_vce_52.c \

Comments

On 02/06/2018 03:05 PM, James Zhu wrote:
> Signed-off-by: James Zhu <James.Zhu@amd.com>
> ---
>   src/gallium/drivers/radeon/Makefile.sources | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/src/gallium/drivers/radeon/Makefile.sources b/src/gallium/drivers/radeon/Makefile.sources
> index b756d72..f8ee860 100644
> --- a/src/gallium/drivers/radeon/Makefile.sources
> +++ b/src/gallium/drivers/radeon/Makefile.sources
> @@ -15,6 +15,9 @@ C_SOURCES := \
>   	radeon_vcn_enc_1_2.c \
>   	radeon_vcn_enc.c \
>   	radeon_vcn_enc.h \
> +	radeon_uvd_enc_1_1.c \
> +	radeon_uvd_enc.c \
> +	radeon_uvd_enc.h \
We need to add this to Meson build as well, like VCN ENC does.


Leo

>   	radeon_vce_40_2_2.c \
>   	radeon_vce_50.c \
>   	radeon_vce_52.c \
Am 07.02.2018 um 15:47 schrieb Leo Liu:
>
>
> On 02/06/2018 03:05 PM, James Zhu wrote:
>> Signed-off-by: James Zhu <James.Zhu@amd.com>
>> ---
>>   src/gallium/drivers/radeon/Makefile.sources | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/src/gallium/drivers/radeon/Makefile.sources 
>> b/src/gallium/drivers/radeon/Makefile.sources
>> index b756d72..f8ee860 100644
>> --- a/src/gallium/drivers/radeon/Makefile.sources
>> +++ b/src/gallium/drivers/radeon/Makefile.sources
>> @@ -15,6 +15,9 @@ C_SOURCES := \
>>       radeon_vcn_enc_1_2.c \
>>       radeon_vcn_enc.c \
>>       radeon_vcn_enc.h \
>> +    radeon_uvd_enc_1_1.c \
>> +    radeon_uvd_enc.c \
>> +    radeon_uvd_enc.h \
> We need to add this to Meson build as well, like VCN ENC does.

And we usually add files to Makefile.source and Meson when they are 
first added/used.

So adding all at once is not the usual approach.

Christian.

>
>
> Leo
>
>>       radeon_vce_40_2_2.c \
>>       radeon_vce_50.c \
>>       radeon_vce_52.c \
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 2018-02-07 09:48 AM, Christian König wrote:
> Am 07.02.2018 um 15:47 schrieb Leo Liu:
>>
>>
>> On 02/06/2018 03:05 PM, James Zhu wrote:
>>> Signed-off-by: James Zhu <James.Zhu@amd.com>
>>> ---
>>>   src/gallium/drivers/radeon/Makefile.sources | 3 +++
>>>   1 file changed, 3 insertions(+)
>>>
>>> diff --git a/src/gallium/drivers/radeon/Makefile.sources 
>>> b/src/gallium/drivers/radeon/Makefile.sources
>>> index b756d72..f8ee860 100644
>>> --- a/src/gallium/drivers/radeon/Makefile.sources
>>> +++ b/src/gallium/drivers/radeon/Makefile.sources
>>> @@ -15,6 +15,9 @@ C_SOURCES := \
>>>       radeon_vcn_enc_1_2.c \
>>>       radeon_vcn_enc.c \
>>>       radeon_vcn_enc.h \
>>> +    radeon_uvd_enc_1_1.c \
>>> +    radeon_uvd_enc.c \
>>> +    radeon_uvd_enc.h \
>> We need to add this to Meson build as well, like VCN ENC does.
>
> And we usually add files to Makefile.source and Meson when they are 
> first added/used.
>
> So adding all at once is not the usual approach.
>
> Christian.
>
Since it needs change other patches, I will keep all at once this time. 
Next time, I will update build list when file is first-time added/used.
thanks! James
>>
>>
>> Leo
>>
>>>       radeon_vce_40_2_2.c \
>>>       radeon_vce_50.c \
>>>       radeon_vce_52.c \
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>