[3/4] anv/cmd_buffer: Emit PIPE_CONTROL with ISP bit on older platforms.

Submitted by Rafael Antognolli on Jan. 26, 2018, 7:32 p.m.

Details

Message ID 20180126193240.15281-4-rafael.antognolli@intel.com
State New
Headers show
Series "Fix messup and extend workaround to older platforms." ( rev: 1 ) in Mesa

Not browsing as part of any series.

Commit Message

Rafael Antognolli Jan. 26, 2018, 7:32 p.m.
Emit it on all platforms since gen7.

Signed-off-by: Rafael Antognolli <rafael.antognolli@intel.com>
---
 src/intel/vulkan/genX_cmd_buffer.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Patch hide | download patch | download mbox

diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c
index 3691b4bdec9..0e8c9ee7c46 100644
--- a/src/intel/vulkan/genX_cmd_buffer.c
+++ b/src/intel/vulkan/genX_cmd_buffer.c
@@ -975,7 +975,7 @@  genX(BeginCommandBuffer)(
     * emit push constants again before any rendering operation. So we
     * flag them dirty here to make sure they get emitted.
     */
-   if (GEN_GEN == 10)
+   if (GEN_GEN >= 7)
       cmd_buffer->state.push_constants_dirty |= VK_SHADER_STAGE_ALL_GRAPHICS;
 
    VkResult result = VK_SUCCESS;
@@ -1074,7 +1074,7 @@  genX(EndCommandBuffer)(
 
    genX(cmd_buffer_apply_pipe_flushes)(cmd_buffer);
 
-   if (GEN_GEN == 10)
+   if (GEN_GEN >= 7)
       emit_isp_disable(cmd_buffer);
 
    anv_cmd_buffer_end_batch_buffer(cmd_buffer);

Comments

Vulkan only supports gen7+.  Go ahead and drop the checks.  With that,

Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>

On Fri, Jan 26, 2018 at 11:32 AM, Rafael Antognolli <
rafael.antognolli@intel.com> wrote:

> Emit it on all platforms since gen7.
>
> Signed-off-by: Rafael Antognolli <rafael.antognolli@intel.com>
> ---
>  src/intel/vulkan/genX_cmd_buffer.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/intel/vulkan/genX_cmd_buffer.c
> b/src/intel/vulkan/genX_cmd_buffer.c
> index 3691b4bdec9..0e8c9ee7c46 100644
> --- a/src/intel/vulkan/genX_cmd_buffer.c
> +++ b/src/intel/vulkan/genX_cmd_buffer.c
> @@ -975,7 +975,7 @@ genX(BeginCommandBuffer)(
>      * emit push constants again before any rendering operation. So we
>      * flag them dirty here to make sure they get emitted.
>      */
> -   if (GEN_GEN == 10)
> +   if (GEN_GEN >= 7)
>        cmd_buffer->state.push_constants_dirty |=
> VK_SHADER_STAGE_ALL_GRAPHICS;
>
>     VkResult result = VK_SUCCESS;
> @@ -1074,7 +1074,7 @@ genX(EndCommandBuffer)(
>
>     genX(cmd_buffer_apply_pipe_flushes)(cmd_buffer);
>
> -   if (GEN_GEN == 10)
> +   if (GEN_GEN >= 7)
>        emit_isp_disable(cmd_buffer);
>
>     anv_cmd_buffer_end_batch_buffer(cmd_buffer);
> --
> 2.14.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>