drm/amdgpu: Temparary disable the sdma use pollmem feature for sriov.

Submitted by Deng, Emily on Jan. 19, 2018, 10:14 a.m.

Details

Message ID 1516356864-2622-1-git-send-email-Emily.Deng@amd.com
State New
Headers show
Series "drm/amdgpu: Temparary disable the sdma use pollmem feature for sriov." ( rev: 1 ) in AMD X.Org drivers

Not browsing as part of any series.

Commit Message

Deng, Emily Jan. 19, 2018, 10:14 a.m.
It still has some serious issues(guest driver reload fail, etc),
when use pollmem feature for sdma3.

Signed-off-by: Emily Deng <Emily.Deng@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
index 3e22ae4..0f8f614 100644
--- a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
@@ -1209,7 +1209,7 @@  static int sdma_v3_0_sw_init(void *handle)
 	for (i = 0; i < adev->sdma.num_instances; i++) {
 		ring = &adev->sdma.instance[i].ring;
 		ring->ring_obj = NULL;
-		if (!amdgpu_sriov_vf(adev)) {
+		if (1) {
 			ring->use_doorbell = true;
 			ring->doorbell_index = (i == 0) ?
 				AMDGPU_DOORBELL_sDMA_ENGINE0 : AMDGPU_DOORBELL_sDMA_ENGINE1;

Comments

Am 19.01.2018 um 11:14 schrieb Emily Deng:
> It still has some serious issues(guest driver reload fail, etc),
> when use pollmem feature for sdma3.
>
> Signed-off-by: Emily Deng <Emily.Deng@amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
> index 3e22ae4..0f8f614 100644
> --- a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
> @@ -1209,7 +1209,7 @@ static int sdma_v3_0_sw_init(void *handle)
>   	for (i = 0; i < adev->sdma.num_instances; i++) {
>   		ring = &adev->sdma.instance[i].ring;
>   		ring->ring_obj = NULL;
> -		if (!amdgpu_sriov_vf(adev)) {
> +		if (1) {

That needs a comment why we have it and I suggest writing this as:

/* Disabled for now because... */
if (true /* !amdgpu_sriov_vf(adev) */)

Regards,
Christian.

>   			ring->use_doorbell = true;
>   			ring->doorbell_index = (i == 0) ?
>   				AMDGPU_DOORBELL_sDMA_ENGINE0 : AMDGPU_DOORBELL_sDMA_ENGINE1;
Hi Christian,
     Thanks your comment, please ignore this patch. Will find out the root cause about why the pollmem doesn't work.

Best Wishes,
Emily Deng



> -----Original Message-----

> From: Christian König [mailto:ckoenig.leichtzumerken@gmail.com]

> Sent: Friday, January 19, 2018 6:22 PM

> To: Deng, Emily <Emily.Deng@amd.com>; amd-gfx@lists.freedesktop.org

> Subject: Re: [PATCH] drm/amdgpu: Temparary disable the sdma use pollmem

> feature for sriov.

> 

> Am 19.01.2018 um 11:14 schrieb Emily Deng:

> > It still has some serious issues(guest driver reload fail, etc), when

> > use pollmem feature for sdma3.

> >

> > Signed-off-by: Emily Deng <Emily.Deng@amd.com>

> > ---

> >   drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | 2 +-

> >   1 file changed, 1 insertion(+), 1 deletion(-)

> >

> > diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c

> > b/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c

> > index 3e22ae4..0f8f614 100644

> > --- a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c

> > +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c

> > @@ -1209,7 +1209,7 @@ static int sdma_v3_0_sw_init(void *handle)

> >   	for (i = 0; i < adev->sdma.num_instances; i++) {

> >   		ring = &adev->sdma.instance[i].ring;

> >   		ring->ring_obj = NULL;

> > -		if (!amdgpu_sriov_vf(adev)) {

> > +		if (1) {

> 

> That needs a comment why we have it and I suggest writing this as:

> 

> /* Disabled for now because... */

> if (true /* !amdgpu_sriov_vf(adev) */)

> 

> Regards,

> Christian.

> 

> >   			ring->use_doorbell = true;

> >   			ring->doorbell_index = (i == 0) ?

> >   				AMDGPU_DOORBELL_sDMA_ENGINE0 :

> AMDGPU_DOORBELL_sDMA_ENGINE1;