[4/4] debugs

Submitted by Ville Syrjala on Jan. 16, 2018, 1:35 p.m.

Details

Message ID 20180116133542.31499-4-ville.syrjala@linux.intel.com
State New
Headers show
Series "Series without cover letter" ( rev: 1 ) in Intel GFX - Try Bot

Not browsing as part of any series.

Commit Message

Ville Syrjala Jan. 16, 2018, 1:35 p.m.
From: Ville Syrjälä <ville.syrjala@linux.intel.com>

---
 drivers/gpu/drm/i915/intel_dp.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

Patch hide | download patch | download mbox

diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 152016e09a11..f64538b46ab3 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -4290,8 +4290,10 @@  intel_dp_needs_link_retrain(struct intel_dp *intel_dp)
 	 * intel_dp->lane_count before attempting to retrain.
 	 */
 	if (!intel_dp_link_params_valid(intel_dp, intel_dp->link_rate,
-					intel_dp->lane_count))
+					intel_dp->lane_count)) {
+		DRM_ERROR("link params invalid\n");
 		return false;
+	}
 
 	/* Retrain if Channel EQ or CR not ok */
 	return !drm_dp_channel_eq_ok(link_status, intel_dp->lane_count);
@@ -4450,6 +4452,8 @@  intel_dp_short_pulse(struct intel_dp *intel_dp)
 	ret = intel_dp_get_dpcd(intel_dp);
 
 	if ((old_sink_count != intel_dp->sink_count) || !ret) {
+		DRM_DEBUG_KMS("sink count %d -> %d, ret %d\n",
+			      old_sink_count, intel_dp->sink_count, ret);
 		/* No need to proceed if we are going to do full detect */
 		return false;
 	}
@@ -4470,8 +4474,10 @@  intel_dp_short_pulse(struct intel_dp *intel_dp)
 	}
 
 	/* defer to the hotplug work for link retraining if needed */
-	if (intel_dp_needs_link_retrain(intel_dp))
+	if (intel_dp_needs_link_retrain(intel_dp)) {
+		DRM_DEBUG_KMS("need link retrain\n");
 		return false;
+	}
 
 	if (intel_dp->compliance.test_type == DP_TEST_LINK_TRAINING) {
 		DRM_DEBUG_KMS("Link Training Compliance Test requested\n");