Is "X server found. dri2 connection failed!" normal on Wayland?

Submitted by Rebecca N. Palmer on Jan. 8, 2018, 9:11 p.m.

Details

Message ID 459e935b-e891-ec9e-7994-2249a83fa6cc@zoho.com
State New
Series "Is "X server found. dri2 connection failed!" normal on Wayland?"
Headers show

Commit Message

Rebecca N. Palmer Jan. 8, 2018, 9:11 p.m.
...and if it is, should we stop printing a warning for it to avoid 
pointlessly scaring users?

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=882486

When I get this warning, everything still seems to work (e.g. the test 
suite passes).  Some other reports have both it and another error (e.g. 
https://bugzilla.redhat.com/show_bug.cgi?id=1478536 ,
https://bugzilla.redhat.com/show_bug.cgi?id=1460400 ), but these may be 
unrelated bugs (e.g. the second is 
https://bugs.freedesktop.org/show_bug.cgi?id=101485 ).

Signed-off-by: Rebecca N. Palmer <rebecca_palmer@zoho.com>

Patch hide | download patch | download mbox

--- a/src/intel/intel_driver.c
+++ b/src/intel/intel_driver.c
@@ -235,8 +235,6 @@  if(intel->x11_display) {
      intel_driver_init_shared(intel, intel->dri_ctx);
      Xfree(driver_name);
    }
-  else
-    fprintf(stderr, "X server found. dri2 connection failed! \n");
  }
  #endif


Comments

Yang, Rong R Jan. 10, 2018, 8:08 a.m.
Yes, this warning is legacy, I will apply your patch, thanks.

> -----Original Message-----

> From: Beignet [mailto:beignet-bounces@lists.freedesktop.org] On Behalf Of

> Rebecca N. Palmer

> Sent: Tuesday, January 9, 2018 5:12 AM

> To: beignet@lists.freedesktop.org

> Subject: [Beignet] Is "X server found. dri2 connection failed!" normal on

> Wayland?

> 

> ...and if it is, should we stop printing a warning for it to avoid pointlessly scaring

> users?

> 

> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=882486

> 

> When I get this warning, everything still seems to work (e.g. the test suite

> passes).  Some other reports have both it and another error (e.g.

> https://bugzilla.redhat.com/show_bug.cgi?id=1478536 ,

> https://bugzilla.redhat.com/show_bug.cgi?id=1460400 ), but these may be

> unrelated bugs (e.g. the second is

> https://bugs.freedesktop.org/show_bug.cgi?id=101485 ).

> 

> Signed-off-by: Rebecca N. Palmer <rebecca_palmer@zoho.com>

> 

> --- a/src/intel/intel_driver.c

> +++ b/src/intel/intel_driver.c

> @@ -235,8 +235,6 @@ if(intel->x11_display) {

>       intel_driver_init_shared(intel, intel->dri_ctx);

>       Xfree(driver_name);

>     }

> -  else

> -    fprintf(stderr, "X server found. dri2 connection failed! \n");

>   }

>   #endif

> 

> 

> _______________________________________________

> Beignet mailing list

> Beignet@lists.freedesktop.org

> https://lists.freedesktop.org/mailman/listinfo/beignet