| Message ID | 20171115152558.31252-1-chris@chris-wilson.co.uk |
|---|---|
| State | Accepted |
| Commit | 4fe95b042d9d36744f6848069a92759c10dd2a0e |
| Headers | show |
| Series |
"drm/i915/selftests: exercise_ggtt may have nothing to do"
( rev:
1
)
in
Intel GFX |
diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c index d9560d8a6cc8..3dcf886a2802 100644 --- a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c +++ b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c @@ -958,7 +958,7 @@ static int exercise_ggtt(struct drm_i915_private *i915, u64 hole_start, hole_end, last = 0; struct drm_mm_node *node; IGT_TIMEOUT(end_time); - int err = -ENODEV; + int err = 0; mutex_lock(&i915->drm.struct_mutex); restart:
Quoting Chris Wilson (2017-11-15 15:25:58) > When operating on the live_ggtt we have to find a usuable hole for our > test. It is possible for there to be no hole we can use, so initialise > the err to 0 for the early exit. > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > --- > drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c > index d9560d8a6cc8..3dcf886a2802 100644 > --- a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c > +++ b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c > @@ -958,7 +958,7 @@ static int exercise_ggtt(struct drm_i915_private *i915, > u64 hole_start, hole_end, last = 0; > struct drm_mm_node *node; > IGT_TIMEOUT(end_time); > - int err = -ENODEV; > + int err = 0; > > mutex_lock(&i915->drm.struct_mutex); > restart: Pushed with a flyby irc review from Joonas, thanks. -Chris
When operating on the live_ggtt we have to find a usuable hole for our test. It is possible for there to be no hole we can use, so initialise the err to 0 for the early exit. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> --- drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)