GBE: Remove TBAA.

Submitted by Song, Ruiling on Oct. 18, 2017, 3:03 a.m.

Details

Message ID 1508295804-16844-1-git-send-email-ruiling.song@intel.com
State New
Headers show
Series "GBE: Remove TBAA." ( rev: 1 ) in Beignet

Not browsing as part of any series.

Commit Message

Song, Ruiling Oct. 18, 2017, 3:03 a.m.
At the time we expand llvm.memcpy. we introduce some load/store
that break the TBAA. This issue comes out in llvm5.0. So we remove
the TBAA from the compilation passes.

Signed-off-by: Ruiling Song <ruiling.song@intel.com>
---
 backend/src/llvm/llvm_to_gen.cpp | 2 --
 1 file changed, 2 deletions(-)

Patch hide | download patch | download mbox

diff --git a/backend/src/llvm/llvm_to_gen.cpp b/backend/src/llvm/llvm_to_gen.cpp
index 8546f73..f679c58 100644
--- a/backend/src/llvm/llvm_to_gen.cpp
+++ b/backend/src/llvm/llvm_to_gen.cpp
@@ -87,7 +87,6 @@  namespace gbe
     FPM.add(new TargetLibraryInfo(*libraryInfo));
 #endif
 #if LLVM_VERSION_MAJOR * 10 + LLVM_VERSION_MINOR >= 38
-    FPM.add(createTypeBasedAAWrapperPass());
     FPM.add(createBasicAAWrapperPass());
 #else
     FPM.add(createTypeBasedAliasAnalysisPass());
@@ -129,7 +128,6 @@  namespace gbe
     MPM.add(new TargetLibraryInfo(*libraryInfo));
 #endif
 #if LLVM_VERSION_MAJOR * 10 + LLVM_VERSION_MINOR >= 38
-    MPM.add(createTypeBasedAAWrapperPass());
     MPM.add(createBasicAAWrapperPass());
 #else
     MPM.add(createTypeBasedAliasAnalysisPass());

Comments

Please skip this patch. I have sent another patch to solve the problem.

Ruiling
> -----Original Message-----
> From: Song, Ruiling
> Sent: Wednesday, October 18, 2017 11:03 AM
> To: beignet@lists.freedesktop.org
> Cc: Song, Ruiling <ruiling.song@intel.com>
> Subject: [PATCH] GBE: Remove TBAA.
> 
> At the time we expand llvm.memcpy. we introduce some load/store
> that break the TBAA. This issue comes out in llvm5.0. So we remove
> the TBAA from the compilation passes.
> 
> Signed-off-by: Ruiling Song <ruiling.song@intel.com>
> ---
>  backend/src/llvm/llvm_to_gen.cpp | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/backend/src/llvm/llvm_to_gen.cpp
> b/backend/src/llvm/llvm_to_gen.cpp
> index 8546f73..f679c58 100644
> --- a/backend/src/llvm/llvm_to_gen.cpp
> +++ b/backend/src/llvm/llvm_to_gen.cpp
> @@ -87,7 +87,6 @@ namespace gbe
>      FPM.add(new TargetLibraryInfo(*libraryInfo));
>  #endif
>  #if LLVM_VERSION_MAJOR * 10 + LLVM_VERSION_MINOR >= 38
> -    FPM.add(createTypeBasedAAWrapperPass());
>      FPM.add(createBasicAAWrapperPass());
>  #else
>      FPM.add(createTypeBasedAliasAnalysisPass());
> @@ -129,7 +128,6 @@ namespace gbe
>      MPM.add(new TargetLibraryInfo(*libraryInfo));
>  #endif
>  #if LLVM_VERSION_MAJOR * 10 + LLVM_VERSION_MINOR >= 38
> -    MPM.add(createTypeBasedAAWrapperPass());
>      MPM.add(createBasicAAWrapperPass());
>  #else
>      MPM.add(createTypeBasedAliasAnalysisPass());
> --
> 2.4.1
LGTM, pushed, thanks.

> -----Original Message-----

> From: Beignet [mailto:beignet-bounces@lists.freedesktop.org] On Behalf Of

> Song, Ruiling

> Sent: Wednesday, October 18, 2017 3:36 PM

> To: beignet@lists.freedesktop.org

> Subject: Re: [Beignet] [PATCH] GBE: Remove TBAA.

> 

> Please skip this patch. I have sent another patch to solve the problem.

> 

> Ruiling

> > -----Original Message-----

> > From: Song, Ruiling

> > Sent: Wednesday, October 18, 2017 11:03 AM

> > To: beignet@lists.freedesktop.org

> > Cc: Song, Ruiling <ruiling.song@intel.com>

> > Subject: [PATCH] GBE: Remove TBAA.

> >

> > At the time we expand llvm.memcpy. we introduce some load/store that

> > break the TBAA. This issue comes out in llvm5.0. So we remove the TBAA

> > from the compilation passes.

> >

> > Signed-off-by: Ruiling Song <ruiling.song@intel.com>

> > ---

> >  backend/src/llvm/llvm_to_gen.cpp | 2 --

> >  1 file changed, 2 deletions(-)

> >

> > diff --git a/backend/src/llvm/llvm_to_gen.cpp

> > b/backend/src/llvm/llvm_to_gen.cpp

> > index 8546f73..f679c58 100644

> > --- a/backend/src/llvm/llvm_to_gen.cpp

> > +++ b/backend/src/llvm/llvm_to_gen.cpp

> > @@ -87,7 +87,6 @@ namespace gbe

> >      FPM.add(new TargetLibraryInfo(*libraryInfo));  #endif  #if

> > LLVM_VERSION_MAJOR * 10 + LLVM_VERSION_MINOR >= 38

> > -    FPM.add(createTypeBasedAAWrapperPass());

> >      FPM.add(createBasicAAWrapperPass());

> >  #else

> >      FPM.add(createTypeBasedAliasAnalysisPass());

> > @@ -129,7 +128,6 @@ namespace gbe

> >      MPM.add(new TargetLibraryInfo(*libraryInfo));  #endif  #if

> > LLVM_VERSION_MAJOR * 10 + LLVM_VERSION_MINOR >= 38

> > -    MPM.add(createTypeBasedAAWrapperPass());

> >      MPM.add(createBasicAAWrapperPass());

> >  #else

> >      MPM.add(createTypeBasedAliasAnalysisPass());

> > --

> > 2.4.1

> 

> _______________________________________________

> Beignet mailing list

> Beignet@lists.freedesktop.org

> https://lists.freedesktop.org/mailman/listinfo/beignet