[10/14] staging:iio:resolver:ad2s1210 fix negative IIO_ANGL_VEL read

Submitted by Arnd Bergmann on July 14, 2017, 9:31 a.m.

Details

Message ID 20170714093129.1366900-1-arnd@arndb.de
State Accepted
Commit 105967ad68d2eb1a041bc041f9cf96af2a653b65
Headers show
Series "gcc-7 warnings" ( rev: 3 2 1 ) in DRI devel

Browsing this patch as part of:
"gcc-7 warnings" rev 1 in DRI devel
<< prev patch [10/14] next patch >>

Commit Message

Arnd Bergmann July 14, 2017, 9:31 a.m.
gcc-7 points out an older regression:

drivers/staging/iio/resolver/ad2s1210.c: In function 'ad2s1210_read_raw':
drivers/staging/iio/resolver/ad2s1210.c:515:42: error: '<<' in boolean context, did you mean '<' ? [-Werror=int-in-bool-context]

The original code had 'unsigned short' here, but incorrectly got
converted to 'bool'. This reverts the regression and uses a normal
type instead.

Fixes: 29148543c521 ("staging:iio:resolver:ad2s1210 minimal chan spec conversion.")
Cc: stable@vger.kernel.org
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/staging/iio/resolver/ad2s1210.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c
index a6a8393d6664..3e00df74b18c 100644
--- a/drivers/staging/iio/resolver/ad2s1210.c
+++ b/drivers/staging/iio/resolver/ad2s1210.c
@@ -472,7 +472,7 @@  static int ad2s1210_read_raw(struct iio_dev *indio_dev,
 			     long m)
 {
 	struct ad2s1210_state *st = iio_priv(indio_dev);
-	bool negative;
+	u16 negative;
 	int ret = 0;
 	u16 pos;
 	s16 vel;