[6/8] arb_separate_shader_objects/atomic-counter: require GLSL 1.50

Submitted by Marek Olšák on April 10, 2017, 9:01 p.m.

Details

Message ID 1491858103-16838-6-git-send-email-maraeo@gmail.com
State New
Headers show
Series "Series without cover letter" ( rev: 1 ) in Piglit

Not browsing as part of any series.

Commit Message

Marek Olšák April 10, 2017, 9:01 p.m.
From: Marek Olšák <marek.olsak@amd.com>

---
 tests/spec/arb_separate_shader_objects/atomic-counter.c | 1 +
 1 file changed, 1 insertion(+)

Patch hide | download patch | download mbox

diff --git a/tests/spec/arb_separate_shader_objects/atomic-counter.c b/tests/spec/arb_separate_shader_objects/atomic-counter.c
index 4e54c8e..d6845b7 100644
--- a/tests/spec/arb_separate_shader_objects/atomic-counter.c
+++ b/tests/spec/arb_separate_shader_objects/atomic-counter.c
@@ -98,20 +98,21 @@  piglit_display(void)
 	return pass ? PIGLIT_PASS : PIGLIT_FAIL;
 }
 
 void
 piglit_init(int argc, char **argv)
 {
 	bool pass = true;
 	uint32_t counter = 0;
 
 	piglit_require_gl_version(31);
+	piglit_require_GLSL_version(150);
 	piglit_require_extension("GL_ARB_shader_atomic_counters");
 	piglit_require_extension("GL_ARB_separate_shader_objects");
 
 	/* Create program pipeline. */
 	glGenProgramPipelines(1, &pipe);
 	glBindProgramPipeline(pipe);
 
 	vs = glCreateShaderProgramv(GL_VERTEX_SHADER, 1, &vs_source);
 	pass = piglit_link_check_status(vs) && pass;
 

Comments

IMHO just bump the core version to 32. (And get rid of the explicit
piglit_require_gl_version call...) Either way,

Reviewed-by: Ilia Mirkin <imirkin@alum.mit.edu>

On Mon, Apr 10, 2017 at 5:01 PM, Marek Olšák <maraeo@gmail.com> wrote:
> From: Marek Olšák <marek.olsak@amd.com>
>
> ---
>  tests/spec/arb_separate_shader_objects/atomic-counter.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tests/spec/arb_separate_shader_objects/atomic-counter.c b/tests/spec/arb_separate_shader_objects/atomic-counter.c
> index 4e54c8e..d6845b7 100644
> --- a/tests/spec/arb_separate_shader_objects/atomic-counter.c
> +++ b/tests/spec/arb_separate_shader_objects/atomic-counter.c
> @@ -98,20 +98,21 @@ piglit_display(void)
>         return pass ? PIGLIT_PASS : PIGLIT_FAIL;
>  }
>
>  void
>  piglit_init(int argc, char **argv)
>  {
>         bool pass = true;
>         uint32_t counter = 0;
>
>         piglit_require_gl_version(31);
> +       piglit_require_GLSL_version(150);
>         piglit_require_extension("GL_ARB_shader_atomic_counters");
>         piglit_require_extension("GL_ARB_separate_shader_objects");
>
>         /* Create program pipeline. */
>         glGenProgramPipelines(1, &pipe);
>         glBindProgramPipeline(pipe);
>
>         vs = glCreateShaderProgramv(GL_VERTEX_SHADER, 1, &vs_source);
>         pass = piglit_link_check_status(vs) && pass;
>
> --
> 2.7.4
>
> _______________________________________________
> Piglit mailing list
> Piglit@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit