[Spice-devel,05/12] qxl-wddm-dod: Reduce amount of unnecessary printouts

Submitted by Yuri Benditovich on March 12, 2017, 8:45 a.m.

Details

Message ID 1489308309-9728-6-git-send-email-yuri.benditovich@daynix.com
State New
Headers show
Series "Set of patches for further support of VSync" ( rev: 1 ) in Spice

Not browsing as part of any series.

Commit Message

Yuri Benditovich March 12, 2017, 8:45 a.m.
Signed-off-by: Yuri Benditovich <yuri.benditovich@daynix.com>
---
 qxldod/QxlDod.cpp | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Patch hide | download patch | download mbox

diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp
index 7e3afb3..7750467 100755
--- a/qxldod/QxlDod.cpp
+++ b/qxldod/QxlDod.cpp
@@ -1743,10 +1743,10 @@  NTSTATUS QxlDod::UpdateActiveVidPnPresentPath(_In_ CONST DXGKARG_UPDATEACTIVEVID
 QXL_NON_PAGED
 VOID QxlDod::DpcRoutine(VOID)
 {
-    DbgPrint(TRACE_LEVEL_INFORMATION, ("---> %s\n", __FUNCTION__));
+    DbgPrint(TRACE_LEVEL_VERBOSE, ("---> %s\n", __FUNCTION__));
     m_pHWDevice->DpcRoutine(&m_DxgkInterface);
     m_DxgkInterface.DxgkCbNotifyDpc((HANDLE)m_DxgkInterface.DeviceHandle);
-    DbgPrint(TRACE_LEVEL_INFORMATION, ("<--- %s\n", __FUNCTION__));
+    DbgPrint(TRACE_LEVEL_VERBOSE, ("<--- %s\n", __FUNCTION__));
 }
 
 QXL_NON_PAGED
@@ -4179,7 +4179,7 @@  BOOL QxlDevice::SetClip(const RECT *clip, QXLDrawable *drawable)
 
     if (clip == NULL) {
         drawable->clip.type = SPICE_CLIP_TYPE_NONE;
-        DbgPrint(TRACE_LEVEL_INFORMATION, ("%s QXL_CLIP_TYPE_NONE\n", __FUNCTION__));
+        // currently we always with NULL clip parameter
         return TRUE;
     }
 
@@ -4891,7 +4891,7 @@  QXL_NON_PAGED
 VOID QxlDevice::DpcRoutine(PVOID)
 {
     LONG intStatus = InterlockedExchange(&m_Pending, 0);
-    DbgPrint(TRACE_LEVEL_INFORMATION, ("---> %s\n", __FUNCTION__));
+    DbgPrint(TRACE_LEVEL_VERBOSE, ("---> %s\n", __FUNCTION__));
 
     if (intStatus & QXL_INTERRUPT_DISPLAY) {
         DbgPrint(TRACE_LEVEL_INFORMATION, ("---> %s m_DisplayEvent\n", __FUNCTION__));
@@ -4906,7 +4906,7 @@  VOID QxlDevice::DpcRoutine(PVOID)
         KeSetEvent (&m_IoCmdEvent, IO_NO_INCREMENT, FALSE);
     }
 
-    DbgPrint(TRACE_LEVEL_INFORMATION, ("<--- %s\n", __FUNCTION__));
+    DbgPrint(TRACE_LEVEL_VERBOSE, ("<--- %s\n", __FUNCTION__));
 }
 
 VOID QxlDevice::UpdateArea(CONST RECT* area, UINT32 surface_id)

Comments

> 
> Signed-off-by: Yuri Benditovich <yuri.benditovich@daynix.com>
> ---
>  qxldod/QxlDod.cpp | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp
> index 7e3afb3..7750467 100755
> --- a/qxldod/QxlDod.cpp
> +++ b/qxldod/QxlDod.cpp
> @@ -1743,10 +1743,10 @@ NTSTATUS QxlDod::UpdateActiveVidPnPresentPath(_In_
> CONST DXGKARG_UPDATEACTIVEVID
>  QXL_NON_PAGED
>  VOID QxlDod::DpcRoutine(VOID)
>  {
> -    DbgPrint(TRACE_LEVEL_INFORMATION, ("---> %s\n", __FUNCTION__));
> +    DbgPrint(TRACE_LEVEL_VERBOSE, ("---> %s\n", __FUNCTION__));
>      m_pHWDevice->DpcRoutine(&m_DxgkInterface);
>      m_DxgkInterface.DxgkCbNotifyDpc((HANDLE)m_DxgkInterface.DeviceHandle);
> -    DbgPrint(TRACE_LEVEL_INFORMATION, ("<--- %s\n", __FUNCTION__));
> +    DbgPrint(TRACE_LEVEL_VERBOSE, ("<--- %s\n", __FUNCTION__));
>  }
>  
>  QXL_NON_PAGED
> @@ -4179,7 +4179,7 @@ BOOL QxlDevice::SetClip(const RECT *clip, QXLDrawable
> *drawable)
>  
>      if (clip == NULL) {
>          drawable->clip.type = SPICE_CLIP_TYPE_NONE;
> -        DbgPrint(TRACE_LEVEL_INFORMATION, ("%s QXL_CLIP_TYPE_NONE\n",
> __FUNCTION__));
> +        // currently we always with NULL clip parameter
>          return TRUE;
>      }
>  
> @@ -4891,7 +4891,7 @@ QXL_NON_PAGED
>  VOID QxlDevice::DpcRoutine(PVOID)
>  {
>      LONG intStatus = InterlockedExchange(&m_Pending, 0);
> -    DbgPrint(TRACE_LEVEL_INFORMATION, ("---> %s\n", __FUNCTION__));
> +    DbgPrint(TRACE_LEVEL_VERBOSE, ("---> %s\n", __FUNCTION__));
>  
>      if (intStatus & QXL_INTERRUPT_DISPLAY) {
>          DbgPrint(TRACE_LEVEL_INFORMATION, ("---> %s m_DisplayEvent\n",
>          __FUNCTION__));
> @@ -4906,7 +4906,7 @@ VOID QxlDevice::DpcRoutine(PVOID)
>          KeSetEvent (&m_IoCmdEvent, IO_NO_INCREMENT, FALSE);
>      }
>  
> -    DbgPrint(TRACE_LEVEL_INFORMATION, ("<--- %s\n", __FUNCTION__));
> +    DbgPrint(TRACE_LEVEL_VERBOSE, ("<--- %s\n", __FUNCTION__));
>  }
>  
>  VOID QxlDevice::UpdateArea(CONST RECT* area, UINT32 surface_id)

Acked-by: Frediano Ziglio <fziglio@redhat.com>

Frediano