[PATCH:libX11,2/8] Let libX11 load and make available the newer (X11R6) callback-based API for XIM (expected by emacs).

Patch from Ian D. Leroux <idleroux@fastmail.fm> on pkgsrc-users
following a hint by Nhat Minh Lê <nhat.minh.le@gmail.com>.
---
 nls/C/XI18N_OBJS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

For patches 2, 4, & 5 from this series, while I have vague memories that
I once knew how those files worked, I certainly don't have access to those
brain cells any more, so will leave these for someone with more familiarity
with the Xlib i18n bits to throw out a reviewed-by tag - I'm willing to push
if someone steps forward to review.   (Or you might get someone like James
Cloos to both review & push, as he does for much of the i18n config changes.)

On Thu, Jun 06, 2013 at 11:17:49PM -0700, Alan Coopersmith wrote:
> For patches 2, 4, & 5 from this series, while I have vague memories that
> I once knew how those files worked, I certainly don't have access to those
> brain cells any more, so will leave these for someone with more familiarity
> with the Xlib i18n bits to throw out a reviewed-by tag - I'm willing to push
> if someone steps forward to review.   (Or you might get someone like James
> Cloos to both review & push, as he does for much of the i18n config changes.)

James, can you please take a look at these? (Patches 2, 4, and 5 from
the patchset).

They basically all look like this:
-XIM    common/ximcp    _XimOpenIM      # XIM_open
+XIM    common/ximcp    _XimOpenIM _XimRegisterIMInstantiateCallback  _XimUnRegisterIMInstantiateCallback # XIM_open    XIM_register XIM_unregister

and were needed by emacs to support Multi_key.

If they are correct, similar changes might be needed in more files.

Thanks,
 Thomas

>>>>> "TK" == Thomas Klausner <wiz@NetBSD.org> writes:

TK> James, can you please take a look at these? (Patches 2, 4, and 5 from
TK> the patchset).

I will.

TK> They basically all look like this:
TK> -XIM    common/ximcp    _XimOpenIM      # XIM_open
TK> +XIM common/ximcp _XimOpenIM _XimRegisterIMInstantiateCallback
TK> _XimUnRegisterIMInstantiateCallback # XIM_open XIM_register
TK> XIM_unregister

TK> and were needed by emacs to support Multi_key.

But it will take some time and effort to remember how those files work. :/

And I don't see this $subject in my xorg-devel inbox.  Based on one of
the message-ids, goog sent me to:

  http://patchwork.freedesktop.org/patch/13775/

Is there anywhere else I also should look?

-JimC

>>>>> "TK" == Thomas Klausner <wiz@NetBSD.org> writes:

TK> They basically all look like this:
TK> -XIM    common/ximcp    _XimOpenIM      # XIM_open
TK> +XIM common/ximcp _XimOpenIM _XimRegisterIMInstantiateCallback
TK> _XimUnRegisterIMInstantiateCallback # XIM_open XIM_register
TK> XIM_unregister

2nd comment:

I see how that file works.

The idea then is to make the common/ximcp locales such as C match the
pattern used for XIM in most of the other common/ximcp locales, yes?

If so, that looks reasonable, given that the majority already do.

-JimC

On Sun, Jun 16, 2013 at 12:59:41AM -0400, James Cloos wrote:
> >>>>> "TK" == Thomas Klausner <wiz@NetBSD.org> writes:
> 
> TK> James, can you please take a look at these? (Patches 2, 4, and 5 from
> TK> the patchset).
> 
> I will.
> 
> TK> They basically all look like this:
> TK> -XIM    common/ximcp    _XimOpenIM      # XIM_open
> TK> +XIM common/ximcp _XimOpenIM _XimRegisterIMInstantiateCallback
> TK> _XimUnRegisterIMInstantiateCallback # XIM_open XIM_register
> TK> XIM_unregister
> 
> TK> and were needed by emacs to support Multi_key.
> 
> But it will take some time and effort to remember how those files work. :/
> 
> And I don't see this $subject in my xorg-devel inbox.  Based on one of
> the message-ids, goog sent me to:
> 
>   http://patchwork.freedesktop.org/patch/13775/
> 
> Is there anywhere else I also should look?

The other two are
http://patchwork.freedesktop.org/patch/13777/
http://patchwork.freedesktop.org/patch/13773/
 Thomas

On Sun, Jun 16, 2013 at 02:37:09AM -0400, James Cloos wrote:
> >>>>> "TK" == Thomas Klausner <wiz@NetBSD.org> writes:
> 
> TK> They basically all look like this:
> TK> -XIM    common/ximcp    _XimOpenIM      # XIM_open
> TK> +XIM common/ximcp _XimOpenIM _XimRegisterIMInstantiateCallback
> TK> _XimUnRegisterIMInstantiateCallback # XIM_open XIM_register
> TK> XIM_unregister
> 
> 2nd comment:
> 
> I see how that file works.
> 
> The idea then is to make the common/ximcp locales such as C match the
> pattern used for XIM in most of the other common/ximcp locales, yes?
> 
> If so, that looks reasonable, given that the majority already do.

Yes, that's the idea. Thanks for looking at it!
 Thomas