[Spice-devel,v3,4/4] qxl-wddm-dod: Use 32 bpp for fallback mode

Submitted by Yuri Benditovich on Feb. 6, 2017, 10:29 p.m.

Details

Message ID 1486420163-171144-5-git-send-email-yuri.benditovich@daynix.com
State New
Headers show
Series "qxl-wddm-dod: fix for black screen after VGA driver enable" ( rev: 3 ) in Spice

Not browsing as part of any series.

Commit Message

Yuri Benditovich Feb. 6, 2017, 10:29 p.m.
The driver uses fallback mode when it does not receive
startup display information from the OS. This change
allows solution for https://bugzilla.redhat.com/show_bug.cgi?id=1417448
without fix in qemu for video mode switch from 32 bpp to 24 bpp.

Signed-off-by: Yuri Benditovich <yuri.benditovich@daynix.com>
---
 qxldod/QxlDod.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp
index 70c1846..630c06f 100755
--- a/qxldod/QxlDod.cpp
+++ b/qxldod/QxlDod.cpp
@@ -4831,7 +4831,7 @@  NTSTATUS HwDeviceInterface::AcquireDisplayInfo(DXGK_DISPLAY_INFORMATION& DispInf
 
     if (DispInfo.Width == 0)
     {
-        DispInfo.ColorFormat = D3DDDIFMT_R8G8B8;
+        DispInfo.ColorFormat = D3DDDIFMT_A8R8G8B8;
         DispInfo.Width = MIN_WIDTH_SIZE;
         DispInfo.Height = MIN_HEIGHT_SIZE;
         DispInfo.Pitch = DispInfo.Width * BPPFromPixelFormat(DispInfo.ColorFormat) / BITS_PER_BYTE;

Comments

On Tue, Feb 07, 2017 at 12:29:23AM +0200, Yuri Benditovich wrote:
> The driver uses fallback mode when it does not receive
> startup display information from the OS. This change
> allows solution for https://bugzilla.redhat.com/show_bug.cgi?id=1417448
> without fix in qemu for video mode switch from 32 bpp to 24 bpp.

Is there a bug reported against QEMU though?

Christophe
I've prepared the patch for QEMU and the patch was discussed with Gerd
Hoffman. He has similar fix in queue, not merged yet, so there is no need
to submit patch for QEMU, existing one will be merged

On Wed, Feb 8, 2017 at 1:18 PM, Christophe Fergeau <cfergeau@redhat.com>
wrote:

> On Tue, Feb 07, 2017 at 12:29:23AM +0200, Yuri Benditovich wrote:
> > The driver uses fallback mode when it does not receive
> > startup display information from the OS. This change
> > allows solution for https://bugzilla.redhat.com/show_bug.cgi?id=1417448
> > without fix in qemu for video mode switch from 32 bpp to 24 bpp.
>
> Is there a bug reported against QEMU though?
>
> Christophe
>
On Wed, Feb 08, 2017 at 06:34:47PM +0200, Yuri Benditovich wrote:
> I've prepared the patch for QEMU and the patch was discussed with Gerd
> Hoffman. He has similar fix in queue, not merged yet, so there is no need
> to submit patch for QEMU, existing one will be merged

Ah thanks, I did not realize this was already fixed/being fixed on the
qemu side :)

Christophe