[Spice-devel,2/4] qxl-wddm-dod: Discard meaningless copy of value

Submitted by Yuri Benditovich on Jan. 30, 2017, 1:25 p.m.

Details

Message ID 1485782738-155840-3-git-send-email-yuri.benditovich@daynix.com
State New
Headers show
Series "qxl-wddm-dod: fix for black screen after VGA driver enable" ( rev: 1 ) in Spice

Not browsing as part of any series.

Commit Message

Yuri Benditovich Jan. 30, 2017, 1:25 p.m.
Signed-off-by: Yuri Benditovich <yuri.benditovich@daynix.com>
---
 qxldod/QxlDod.cpp | 6 ------
 1 file changed, 6 deletions(-)

Patch hide | download patch | download mbox

diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp
index 46176f0..459fcb1 100755
--- a/qxldod/QxlDod.cpp
+++ b/qxldod/QxlDod.cpp
@@ -4815,7 +4815,6 @@  UINT SpiceFromPixelFormat(D3DDDIFORMAT Format)
 NTSTATUS HwDeviceInterface::AcquireDisplayInfo(DXGK_DISPLAY_INFORMATION& DispInfo)
 {
     NTSTATUS Status = STATUS_SUCCESS;
-    PHYSICAL_ADDRESS PhysicAddress;
     if (GetId() == 0)
     {
         Status = m_pQxlDod->AcquireDisplayInfo(DispInfo);
@@ -4827,7 +4826,6 @@  NTSTATUS HwDeviceInterface::AcquireDisplayInfo(DXGK_DISPLAY_INFORMATION& DispInf
             Status, DispInfo.Width));
         return STATUS_UNSUCCESSFUL;
     }
-    PhysicAddress.QuadPart = DispInfo.PhysicAddress.QuadPart;
 
     if (DispInfo.Width == 0)
     {
@@ -4836,10 +4834,6 @@  NTSTATUS HwDeviceInterface::AcquireDisplayInfo(DXGK_DISPLAY_INFORMATION& DispInf
         DispInfo.Pitch = MIN_WIDTH_SIZE * BPPFromPixelFormat(D3DDDIFMT_R8G8B8) / 8;
         DispInfo.ColorFormat = D3DDDIFMT_R8G8B8;
         DispInfo.TargetId = 0;
-        if (PhysicAddress.QuadPart != 0L)
-        {
-            DispInfo.PhysicAddress.QuadPart = PhysicAddress.QuadPart;
-        }
     }
     return Status;
 }

Comments

> 
> Signed-off-by: Yuri Benditovich <yuri.benditovich@daynix.com>

Acked-by: Frediano Ziglio <fziglio@redhat.com>

> ---
>  qxldod/QxlDod.cpp | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp
> index 46176f0..459fcb1 100755
> --- a/qxldod/QxlDod.cpp
> +++ b/qxldod/QxlDod.cpp
> @@ -4815,7 +4815,6 @@ UINT SpiceFromPixelFormat(D3DDDIFORMAT Format)
>  NTSTATUS HwDeviceInterface::AcquireDisplayInfo(DXGK_DISPLAY_INFORMATION&
>  DispInfo)
>  {
>      NTSTATUS Status = STATUS_SUCCESS;
> -    PHYSICAL_ADDRESS PhysicAddress;
>      if (GetId() == 0)
>      {
>          Status = m_pQxlDod->AcquireDisplayInfo(DispInfo);
> @@ -4827,7 +4826,6 @@ NTSTATUS
> HwDeviceInterface::AcquireDisplayInfo(DXGK_DISPLAY_INFORMATION& DispInf
>              Status, DispInfo.Width));
>          return STATUS_UNSUCCESSFUL;
>      }
> -    PhysicAddress.QuadPart = DispInfo.PhysicAddress.QuadPart;
>  
>      if (DispInfo.Width == 0)
>      {
> @@ -4836,10 +4834,6 @@ NTSTATUS
> HwDeviceInterface::AcquireDisplayInfo(DXGK_DISPLAY_INFORMATION& DispInf
>          DispInfo.Pitch = MIN_WIDTH_SIZE *
>          BPPFromPixelFormat(D3DDDIFMT_R8G8B8) / 8;
>          DispInfo.ColorFormat = D3DDDIFMT_R8G8B8;
>          DispInfo.TargetId = 0;
> -        if (PhysicAddress.QuadPart != 0L)
> -        {
> -            DispInfo.PhysicAddress.QuadPart = PhysicAddress.QuadPart;
> -        }
>      }
>      return Status;
>  }

Frediano