[Spice-devel] spice-common: remove version construction

Submitted by Michael Tokarev on Feb. 7, 2013, 4:52 p.m.

Details

Message ID 1360255935-24510-1-git-send-email-mjt@msgid.tls.msk.ru
State New
Headers show

Not browsing as part of any series.

Commit Message

Michael Tokarev Feb. 7, 2013, 4:52 p.m.
Version string isn't used anywhere in spice-common, and there's
no version for spice-common module per se, either.  Hoever,
configure.ac has this:

 AC_INIT([spice-common],
         [m4_esyscmd(build-aux/git-version-gen .tarball-version)],
         [spice-devel@lists.freedesktop.org])

But since git-version-gen script is not provided in spice-common
module, multiple error messages are produced when generating
configure (running autogen/autoreconf), like this:

  sh: ./build-aux/git-version-gen: not found

(repeated about 50 times).

The following trivial patch removes usage of build-aux/git-version-gen
from AC_INIT and replaces it with a string "noversion", to stop
these scary messages from being produced.

Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 spice-common/configure.ac |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/spice-common/configure.ac b/spice-common/configure.ac
index c4b0f08..b5cb960 100644
--- a/spice-common/configure.ac
+++ b/spice-common/configure.ac
@@ -1,7 +1,7 @@ 
 AC_PREREQ([2.63])
 
 AC_INIT([spice-common],
-        [m4_esyscmd(build-aux/git-version-gen .tarball-version)],
+        [noversion],
         [spice-devel@lists.freedesktop.org])
 
 AC_CONFIG_SRCDIR([common/bitops.h])

Comments

----- Mensaje original -----
> Version string isn't used anywhere in spice-common, and there's
> no version for spice-common module per se, either.  Hoever,
> configure.ac has this:
> 
>  AC_INIT([spice-common],
>          [m4_esyscmd(build-aux/git-version-gen .tarball-version)],
>          [spice-devel@lists.freedesktop.org])
> 
> But since git-version-gen script is not provided in spice-common
> module, multiple error messages are produced when generating
> configure (running autogen/autoreconf), like this:
> 
>   sh: ./build-aux/git-version-gen: not found
> 
> (repeated about 50 times).

I suppose you are doing a autoreconf from a tarball directory.
Hmm, what about spice-protocol? Do you also have the same warning?
Shipping the git-version-gen is a solution too I suppose.
07.02.2013 21:02, Marc-André Lureau wrote:
> ----- Mensaje original -----
>> Version string isn't used anywhere in spice-common, and there's
>> no version for spice-common module per se, either.  Hoever,
>> configure.ac has this:
>>
>>   AC_INIT([spice-common],
>>           [m4_esyscmd(build-aux/git-version-gen .tarball-version)],
>>           [spice-devel@lists.freedesktop.org])
>>
>> But since git-version-gen script is not provided in spice-common
>> module, multiple error messages are produced when generating
>> configure (running autogen/autoreconf), like this:
>>
>>    sh: ./build-aux/git-version-gen: not found
>>
>> (repeated about 50 times).
>
> I suppose you are doing a autoreconf from a tarball directory.

Yes, after modifying ./configure.ac or some other files it is necessary.

> Hmm, what about spice-protocol? Do you also have the same warning?

spice-protocol has explicit version in configure.ac, like this:

  m4_define([SPICE_MAJOR], 0)
  m4_define([SPICE_MINOR], 12)
  m4_define([SPICE_MICRO], 2)
  AC_INIT(spice-protocol, [SPICE_MAJOR.SPICE_MINOR.SPICE_MICRO], [], spice-protocol)

> Shipping the git-version-gen is a solution too I suppose.

The thing is that this version string is not used anywhere
in spie-common.  Spice-common has no version number per se,
since it is not a separate/stand-alone project.

Thanks,

/mjt
----- Mensaje original -----
> 07.02.2013 21:02, Marc-André Lureau wrote:
> > ----- Mensaje original -----
> >> Version string isn't used anywhere in spice-common, and there's
> >> no version for spice-common module per se, either.  Hoever,
> >> configure.ac has this:
> >>
> >>   AC_INIT([spice-common],
> >>           [m4_esyscmd(build-aux/git-version-gen
> >>           .tarball-version)],
> >>           [spice-devel@lists.freedesktop.org])
> >>
> >> But since git-version-gen script is not provided in spice-common
> >> module, multiple error messages are produced when generating
> >> configure (running autogen/autoreconf), like this:
> >>
> >>    sh: ./build-aux/git-version-gen: not found
> >>
> >> (repeated about 50 times).
> >
> > I suppose you are doing a autoreconf from a tarball directory.
> 
> Yes, after modifying ./configure.ac or some other files it is
> necessary.
> 
> > Hmm, what about spice-protocol? Do you also have the same warning?
> 
> spice-protocol has explicit version in configure.ac, like this:
> 
>   m4_define([SPICE_MAJOR], 0)
>   m4_define([SPICE_MINOR], 12)
>   m4_define([SPICE_MICRO], 2)
>   AC_INIT(spice-protocol, [SPICE_MAJOR.SPICE_MINOR.SPICE_MICRO], [],
>   spice-protocol)
> 
> > Shipping the git-version-gen is a solution too I suppose.
> 
> The thing is that this version string is not used anywhere
> in spie-common.  Spice-common has no version number per se,
> since it is not a separate/stand-alone project.

I agree. Originally, the plan was to make spice-common actually a separate library. But it needs a lot of cleanup for that to happen. So has you found out, there is no need for git-version-gen at all atm.

ack, I'll check your patch doesn't break basic stuff, and apply.