[1/2] xfree86: set event->detail for DGA pointer events

Submitted by Peter Hutterer on Jan. 8, 2013, 1:51 a.m.

Details

Message ID 1357609894-14668-1-git-send-email-peter.hutterer@who-t.net
State Accepted
Commit c5f2818edbec2f87383baa6c6be5c389b73ca6f9
Headers show

Not browsing as part of any series.

Commit Message

Peter Hutterer Jan. 8, 2013, 1:51 a.m.
Reported-by: Steven Elliott <selliott4@austin.rr.com>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
---
 hw/xfree86/common/xf86DGA.c | 1 +
 1 file changed, 1 insertion(+)

Patch hide | download patch | download mbox

diff --git a/hw/xfree86/common/xf86DGA.c b/hw/xfree86/common/xf86DGA.c
index c25a274..c10dd32 100644
--- a/hw/xfree86/common/xf86DGA.c
+++ b/hw/xfree86/common/xf86DGA.c
@@ -1074,6 +1074,7 @@  DGAProcessPointerEvent(ScreenPtr pScreen, DGAEvent * event, DeviceIntPtr mouse)
     DeviceEvent ev = {
         .header = ET_Internal,
         .length = sizeof(ev),
+        .detail.key = event->detail,
         .type = event->subtype,
         .corestate = butc ? butc->state : 0
     };

Comments

> Reported-by: Steven Elliott <selliott4@austin.rr.com>
> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

Does what it says,

Reviewed-by: Dave Airlie <airlied@redhat.com>
> ---
>  hw/xfree86/common/xf86DGA.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/hw/xfree86/common/xf86DGA.c b/hw/xfree86/common/xf86DGA.c
> index c25a274..c10dd32 100644
> --- a/hw/xfree86/common/xf86DGA.c
> +++ b/hw/xfree86/common/xf86DGA.c
> @@ -1074,6 +1074,7 @@ DGAProcessPointerEvent(ScreenPtr pScreen, DGAEvent * event, DeviceIntPtr mouse)
>      DeviceEvent ev = {
>          .header = ET_Internal,
>          .length = sizeof(ev),
> +        .detail.key = event->detail,
>          .type = event->subtype,
>          .corestate = butc ? butc->state : 0
>      };
> --
> 1.8.1
>
> _______________________________________________
> xorg-devel@lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
Hi,

On 7 January 2013 17:51, Peter Hutterer <peter.hutterer@who-t.net> wrote:

> @@ -1074,6 +1074,7 @@ DGAProcessPointerEvent(ScreenPtr pScreen, DGAEvent *
> event, DeviceIntPtr mouse)
>      DeviceEvent ev = {
>          .header = ET_Internal,
>          .length = sizeof(ev),
> +        .detail.key = event->detail,
>          .type = event->subtype,
>          .corestate = butc ? butc->state : 0
>      };
>

Shouldn't this be detail.button?

Cheers,
Daniel
On Thu, Jan 10, 2013 at 06:11:20PM -0800, Daniel Stone wrote:
> Hi,
> 
> On 7 January 2013 17:51, Peter Hutterer <peter.hutterer@who-t.net> wrote:
> 
> > @@ -1074,6 +1074,7 @@ DGAProcessPointerEvent(ScreenPtr pScreen, DGAEvent *
> > event, DeviceIntPtr mouse)
> >      DeviceEvent ev = {
> >          .header = ET_Internal,
> >          .length = sizeof(ev),
> > +        .detail.key = event->detail,
> >          .type = event->subtype,
> >          .corestate = butc ? butc->state : 0
> >      };
> >
> 
> Shouldn't this be detail.button?

true, I'll fix this. it's a union though, so no big deal here.

Cheers,
   Peter