[Spice-devel,spice-common] marshaller: Remove deprecated replacement functions

Submitted by Frediano Ziglio on Dec. 8, 2016, 1:37 p.m.

Details

Message ID 20161208133712.31804-1-fziglio@redhat.com
State Accepted
Commit 86dcd22d334a4992718780417bc574623bd61826
Headers show
Series "marshaller: Remove deprecated replacement functions" ( rev: 1 ) in Spice

Not browsing as part of any series.

Commit Message

Frediano Ziglio Dec. 8, 2016, 1:37 p.m.
spice-common has no stable ABI/API.
Also these function caused linking problems as these functions
were defined multiple times.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
---
 common/marshaller.h | 13 -------------
 1 file changed, 13 deletions(-)

Patch hide | download patch | download mbox

diff --git a/common/marshaller.h b/common/marshaller.h
index 9ae1bdf..0c27a48 100644
--- a/common/marshaller.h
+++ b/common/marshaller.h
@@ -42,19 +42,6 @@  uint8_t *spice_marshaller_add_by_ref(SpiceMarshaller *m, const uint8_t *data, si
 uint8_t *spice_marshaller_add_by_ref_full(SpiceMarshaller *m, uint8_t *data, size_t size,
                                           spice_marshaller_item_free_func free_data, void *opaque);
 void spice_marshaller_add_chunks_by_ref(SpiceMarshaller *m, SpiceChunks *chunks);
-SPICE_GNUC_DEPRECATED inline uint8_t *spice_marshaller_add_ref(SpiceMarshaller *m, const uint8_t *data, size_t size)
-{
-    return spice_marshaller_add_by_ref(m, data, size);
-}
-SPICE_GNUC_DEPRECATED inline uint8_t *spice_marshaller_add_ref_full(SpiceMarshaller *m, uint8_t *data, size_t size,
-                                              spice_marshaller_item_free_func free_data, void *opaque)
-{
-    return spice_marshaller_add_by_ref_full(m, data, size, free_data, opaque);
-}
-SPICE_GNUC_DEPRECATED inline void spice_marshaller_add_ref_chunks(SpiceMarshaller *m, SpiceChunks *chunks)
-{
-    spice_marshaller_add_chunks_by_ref(m, chunks);
-}
 void spice_marshaller_flush(SpiceMarshaller *m);
 void spice_marshaller_set_base(SpiceMarshaller *m, size_t base);
 uint8_t *spice_marshaller_linearize(SpiceMarshaller *m, size_t skip,

Comments

Ack from me

Pavel

On Thu, 2016-12-08 at 13:37 +0000, Frediano Ziglio wrote:
> spice-common has no stable ABI/API.
> Also these function caused linking problems as these functions
> were defined multiple times.
> 
> Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
> ---
>  common/marshaller.h | 13 -------------
>  1 file changed, 13 deletions(-)
> 
> diff --git a/common/marshaller.h b/common/marshaller.h
> index 9ae1bdf..0c27a48 100644
> --- a/common/marshaller.h
> +++ b/common/marshaller.h
> @@ -42,19 +42,6 @@ uint8_t
> *spice_marshaller_add_by_ref(SpiceMarshaller *m, const uint8_t
> *data, si
>  uint8_t *spice_marshaller_add_by_ref_full(SpiceMarshaller *m,
> uint8_t *data, size_t size,
>                                            spice_marshaller_item_fre
> e_func free_data, void *opaque);
>  void spice_marshaller_add_chunks_by_ref(SpiceMarshaller *m,
> SpiceChunks *chunks);
> -SPICE_GNUC_DEPRECATED inline uint8_t
> *spice_marshaller_add_ref(SpiceMarshaller *m, const uint8_t *data,
> size_t size)
> -{
> -    return spice_marshaller_add_by_ref(m, data, size);
> -}
> -SPICE_GNUC_DEPRECATED inline uint8_t
> *spice_marshaller_add_ref_full(SpiceMarshaller *m, uint8_t *data,
> size_t size,
> -                                              spice_marshaller_item
> _free_func free_data, void *opaque)
> -{
> -    return spice_marshaller_add_by_ref_full(m, data, size,
> free_data, opaque);
> -}
> -SPICE_GNUC_DEPRECATED inline void
> spice_marshaller_add_ref_chunks(SpiceMarshaller *m, SpiceChunks
> *chunks)
> -{
> -    spice_marshaller_add_chunks_by_ref(m, chunks);
> -}
>  void spice_marshaller_flush(SpiceMarshaller *m);
>  void spice_marshaller_set_base(SpiceMarshaller *m, size_t base);
>  uint8_t *spice_marshaller_linearize(SpiceMarshaller *m, size_t
> skip,