[Spice-devel,v1] Fix gitignore

Submitted by Victor Toso on Dec. 8, 2016, 1:30 p.m.

Details

Message ID 20161208133020.10887-1-victortoso@redhat.com
State Accepted
Commit 8faf7a6f4549244f2cd977df29ed4414c7346539
Headers show
Series "Fix gitignore" ( rev: 1 ) in Spice

Not browsing as part of any series.

Commit Message

Victor Toso Dec. 8, 2016, 1:30 p.m.
From: Victor Toso <me@victortoso.com>

Signed-off-by: Victor Toso <victortoso@redhat.com>
---
 .gitignore              |  4 ++++
 server/tests/.gitignore | 37 ++++++++++++++++++++++---------------
 tools/.gitignore        |  1 +
 3 files changed, 27 insertions(+), 15 deletions(-)
 create mode 100644 tools/.gitignore

Patch hide | download patch | download mbox

diff --git a/.gitignore b/.gitignore
index 2df7c3f..44eb2b5 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,8 +1,10 @@ 
 *~
+*.o
 .*.sw?
 *.tar.bz2
 *.tar.gz
 *.pyc
+*.html
 aclocal.m4
 autom4te.cache
 compile
@@ -35,3 +37,5 @@  docs/manual/manual.chunked/
 docs/manual/manual.html
 spice-server-enums.h
 spice-server-enums.c
+.dirstamp
+.deps
diff --git a/server/tests/.gitignore b/server/tests/.gitignore
index 3b4544f..a360297 100644
--- a/server/tests/.gitignore
+++ b/server/tests/.gitignore
@@ -1,17 +1,24 @@ 
-test_display_no_ssl
-test_display_streaming
-test_empty_success
-test_just_sockets_no_ssl
-test_fail_on_null_core_interface
-test_playback
-test_display_resolution_changes
 spice-server-replay
-test_display_width_stride
-test_two_servers
-test_vdagent
-stat_test
-libstat_test1.a
-libstat_test2.a
-libstat_test3.a
-libstat_test4.a
 libtest.a
+libtest-stat1.a
+libtest-stat2.a
+libtest-stat3.a
+libtest-stat4.a
+test-agent-msg-filter
+test-codecs-parsing
+test-display-no-ssl
+test-display-resolution-changes
+test-display-streaming
+test-display-width-stride
+test-empty-success
+test-fail-on-null-core-interface
+test-just-sockets-no-ssl
+test-loop
+test-options
+test-playback
+test-qxl-parsing
+test-stat
+test-stat-file
+test-stream
+test-two-servers
+test-vdagent
diff --git a/tools/.gitignore b/tools/.gitignore
new file mode 100644
index 0000000..96fa383
--- /dev/null
+++ b/tools/.gitignore
@@ -0,0 +1 @@ 
+reds_stat

Comments

Ack

Would be good to generate it (git.mk)

Pavel

On Thu, 2016-12-08 at 14:30 +0100, Victor Toso wrote:
> From: Victor Toso <me@victortoso.com>
> 
> Signed-off-by: Victor Toso <victortoso@redhat.com>
> ---
>  .gitignore              |  4 ++++
>  server/tests/.gitignore | 37 ++++++++++++++++++++++---------------
>  tools/.gitignore        |  1 +
>  3 files changed, 27 insertions(+), 15 deletions(-)
>  create mode 100644 tools/.gitignore
> 
> diff --git a/.gitignore b/.gitignore
> index 2df7c3f..44eb2b5 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -1,8 +1,10 @@
>  *~
> +*.o
>  .*.sw?
>  *.tar.bz2
>  *.tar.gz
>  *.pyc
> +*.html
>  aclocal.m4
>  autom4te.cache
>  compile
> @@ -35,3 +37,5 @@ docs/manual/manual.chunked/
>  docs/manual/manual.html
>  spice-server-enums.h
>  spice-server-enums.c
> +.dirstamp
> +.deps
> diff --git a/server/tests/.gitignore b/server/tests/.gitignore
> index 3b4544f..a360297 100644
> --- a/server/tests/.gitignore
> +++ b/server/tests/.gitignore
> @@ -1,17 +1,24 @@
> -test_display_no_ssl
> -test_display_streaming
> -test_empty_success
> -test_just_sockets_no_ssl
> -test_fail_on_null_core_interface
> -test_playback
> -test_display_resolution_changes
>  spice-server-replay
> -test_display_width_stride
> -test_two_servers
> -test_vdagent
> -stat_test
> -libstat_test1.a
> -libstat_test2.a
> -libstat_test3.a
> -libstat_test4.a
>  libtest.a
> +libtest-stat1.a
> +libtest-stat2.a
> +libtest-stat3.a
> +libtest-stat4.a
> +test-agent-msg-filter
> +test-codecs-parsing
> +test-display-no-ssl
> +test-display-resolution-changes
> +test-display-streaming
> +test-display-width-stride
> +test-empty-success
> +test-fail-on-null-core-interface
> +test-just-sockets-no-ssl
> +test-loop
> +test-options
> +test-playback
> +test-qxl-parsing
> +test-stat
> +test-stat-file
> +test-stream
> +test-two-servers
> +test-vdagent
> diff --git a/tools/.gitignore b/tools/.gitignore
> new file mode 100644
> index 0000000..96fa383
> --- /dev/null
> +++ b/tools/.gitignore
> @@ -0,0 +1 @@
> +reds_stat
> 
> From: Victor Toso <me@victortoso.com>
> 
> Signed-off-by: Victor Toso <victortoso@redhat.com>
> ---
>  .gitignore              |  4 ++++
>  server/tests/.gitignore | 37 ++++++++++++++++++++++---------------
>  tools/.gitignore        |  1 +
>  3 files changed, 27 insertions(+), 15 deletions(-)
>  create mode 100644 tools/.gitignore
> 
> diff --git a/.gitignore b/.gitignore
> index 2df7c3f..44eb2b5 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -1,8 +1,10 @@
>  *~
> +*.o

Perhaps can be removed from server/.gitignore.

>  .*.sw?
>  *.tar.bz2
>  *.tar.gz
>  *.pyc
> +*.html

This "all html" looks a bit strong to me.

>  aclocal.m4
>  autom4te.cache
>  compile
> @@ -35,3 +37,5 @@ docs/manual/manual.chunked/
>  docs/manual/manual.html
>  spice-server-enums.h
>  spice-server-enums.c

OT: perhaps these should be moved to server/.gitignore

> +.dirstamp
> +.deps
> diff --git a/server/tests/.gitignore b/server/tests/.gitignore
> index 3b4544f..a360297 100644
> --- a/server/tests/.gitignore
> +++ b/server/tests/.gitignore
> @@ -1,17 +1,24 @@
> -test_display_no_ssl
> -test_display_streaming
> -test_empty_success
> -test_just_sockets_no_ssl
> -test_fail_on_null_core_interface
> -test_playback
> -test_display_resolution_changes
>  spice-server-replay
> -test_display_width_stride
> -test_two_servers
> -test_vdagent
> -stat_test
> -libstat_test1.a
> -libstat_test2.a
> -libstat_test3.a
> -libstat_test4.a
>  libtest.a
> +libtest-stat1.a
> +libtest-stat2.a
> +libtest-stat3.a
> +libtest-stat4.a
> +test-agent-msg-filter
> +test-codecs-parsing
> +test-display-no-ssl
> +test-display-resolution-changes
> +test-display-streaming
> +test-display-width-stride
> +test-empty-success
> +test-fail-on-null-core-interface
> +test-just-sockets-no-ssl
> +test-loop
> +test-options
> +test-playback
> +test-qxl-parsing
> +test-stat
> +test-stat-file
> +test-stream
> +test-two-servers
> +test-vdagent

Indeed, I missed these during the rename!

> diff --git a/tools/.gitignore b/tools/.gitignore
> new file mode 100644
> index 0000000..96fa383
> --- /dev/null
> +++ b/tools/.gitignore
> @@ -0,0 +1 @@
> +reds_stat

My fault too!

Frediano
Hi,

On Thu, Dec 08, 2016 at 03:10:44PM +0100, Pavel Grunt wrote:
> Ack
>
> Would be good to generate it (git.mk)

Agreed. I don't understand much about it.. we already use some cfg.mk in
spice while we have included this git.mk in spice-gtk

I'll push this for now.

  toso

>
> Pavel
> 
> On Thu, 2016-12-08 at 14:30 +0100, Victor Toso wrote:
> > From: Victor Toso <me@victortoso.com>
> > 
> > Signed-off-by: Victor Toso <victortoso@redhat.com>
> > ---
> >  .gitignore              |  4 ++++
> >  server/tests/.gitignore | 37 ++++++++++++++++++++++---------------
> >  tools/.gitignore        |  1 +
> >  3 files changed, 27 insertions(+), 15 deletions(-)
> >  create mode 100644 tools/.gitignore
> > 
> > diff --git a/.gitignore b/.gitignore
> > index 2df7c3f..44eb2b5 100644
> > --- a/.gitignore
> > +++ b/.gitignore
> > @@ -1,8 +1,10 @@
> >  *~
> > +*.o
> >  .*.sw?
> >  *.tar.bz2
> >  *.tar.gz
> >  *.pyc
> > +*.html
> >  aclocal.m4
> >  autom4te.cache
> >  compile
> > @@ -35,3 +37,5 @@ docs/manual/manual.chunked/
> >  docs/manual/manual.html
> >  spice-server-enums.h
> >  spice-server-enums.c
> > +.dirstamp
> > +.deps
> > diff --git a/server/tests/.gitignore b/server/tests/.gitignore
> > index 3b4544f..a360297 100644
> > --- a/server/tests/.gitignore
> > +++ b/server/tests/.gitignore
> > @@ -1,17 +1,24 @@
> > -test_display_no_ssl
> > -test_display_streaming
> > -test_empty_success
> > -test_just_sockets_no_ssl
> > -test_fail_on_null_core_interface
> > -test_playback
> > -test_display_resolution_changes
> >  spice-server-replay
> > -test_display_width_stride
> > -test_two_servers
> > -test_vdagent
> > -stat_test
> > -libstat_test1.a
> > -libstat_test2.a
> > -libstat_test3.a
> > -libstat_test4.a
> >  libtest.a
> > +libtest-stat1.a
> > +libtest-stat2.a
> > +libtest-stat3.a
> > +libtest-stat4.a
> > +test-agent-msg-filter
> > +test-codecs-parsing
> > +test-display-no-ssl
> > +test-display-resolution-changes
> > +test-display-streaming
> > +test-display-width-stride
> > +test-empty-success
> > +test-fail-on-null-core-interface
> > +test-just-sockets-no-ssl
> > +test-loop
> > +test-options
> > +test-playback
> > +test-qxl-parsing
> > +test-stat
> > +test-stat-file
> > +test-stream
> > +test-two-servers
> > +test-vdagent
> > diff --git a/tools/.gitignore b/tools/.gitignore
> > new file mode 100644
> > index 0000000..96fa383
> > --- /dev/null
> > +++ b/tools/.gitignore
> > @@ -0,0 +1 @@
> > +reds_stat
Hi,

Sorry, I pushed already.

On Thu, Dec 08, 2016 at 09:15:57AM -0500, Frediano Ziglio wrote:
> > 
> > From: Victor Toso <me@victortoso.com>
> > 
> > Signed-off-by: Victor Toso <victortoso@redhat.com>
> > ---
> >  .gitignore              |  4 ++++
> >  server/tests/.gitignore | 37 ++++++++++++++++++++++---------------
> >  tools/.gitignore        |  1 +
> >  3 files changed, 27 insertions(+), 15 deletions(-)
> >  create mode 100644 tools/.gitignore
> > 
> > diff --git a/.gitignore b/.gitignore
> > index 2df7c3f..44eb2b5 100644
> > --- a/.gitignore
> > +++ b/.gitignore
> > @@ -1,8 +1,10 @@
> >  *~
> > +*.o
>
> Perhaps can be removed from server/.gitignore.

It could

>
> >  .*.sw?
> >  *.tar.bz2
> >  *.tar.gz
> >  *.pyc
> > +*.html
>
> This "all html" looks a bit strong to me.

Unless we have html templates, I don't see why

>
> >  aclocal.m4
> >  autom4te.cache
> >  compile
> > @@ -35,3 +37,5 @@ docs/manual/manual.chunked/
> >  docs/manual/manual.html
> >  spice-server-enums.h
> >  spice-server-enums.c
>
> OT: perhaps these should be moved to server/.gitignore

It could as well. Although I agree with Pavel that we should have
automatic gitignore generation instead of hand picking these things.

>
> > +.dirstamp
> > +.deps
> > diff --git a/server/tests/.gitignore b/server/tests/.gitignore
> > index 3b4544f..a360297 100644
> > --- a/server/tests/.gitignore
> > +++ b/server/tests/.gitignore
> > @@ -1,17 +1,24 @@
> > -test_display_no_ssl
> > -test_display_streaming
> > -test_empty_success
> > -test_just_sockets_no_ssl
> > -test_fail_on_null_core_interface
> > -test_playback
> > -test_display_resolution_changes
> >  spice-server-replay
> > -test_display_width_stride
> > -test_two_servers
> > -test_vdagent
> > -stat_test
> > -libstat_test1.a
> > -libstat_test2.a
> > -libstat_test3.a
> > -libstat_test4.a
> >  libtest.a
> > +libtest-stat1.a
> > +libtest-stat2.a
> > +libtest-stat3.a
> > +libtest-stat4.a
> > +test-agent-msg-filter
> > +test-codecs-parsing
> > +test-display-no-ssl
> > +test-display-resolution-changes
> > +test-display-streaming
> > +test-display-width-stride
> > +test-empty-success
> > +test-fail-on-null-core-interface
> > +test-just-sockets-no-ssl
> > +test-loop
> > +test-options
> > +test-playback
> > +test-qxl-parsing
> > +test-stat
> > +test-stat-file
> > +test-stream
> > +test-two-servers
> > +test-vdagent
>
> Indeed, I missed these during the rename!
>
> > diff --git a/tools/.gitignore b/tools/.gitignore
> > new file mode 100644
> > index 0000000..96fa383
> > --- /dev/null
> > +++ b/tools/.gitignore
> > @@ -0,0 +1 @@
> > +reds_stat
>
> My fault too!

no problem :)

  toso
>
> Frediano