[Spice-devel,v5,5/8] replay: Free spice server to detect leaks

Submitted by Frediano Ziglio on Dec. 5, 2016, 12:16 p.m.

Details

Message ID 2998edc4cd57350b5b0a9a602042f41e31e30f06.1480940153.git-series.fziglio@redhat.com
State Accepted
Headers show
Series "Start cleaning objects on destruction" ( rev: 7 ) in Spice

Not browsing as part of any series.

Commit Message

Frediano Ziglio Dec. 5, 2016, 12:16 p.m.
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
Acked-by: Pavel Grunt <pgrunt@redhat.com>
---
 server/tests/replay.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/server/tests/replay.c b/server/tests/replay.c
index f32fa2f..23d4125 100644
--- a/server/tests/replay.c
+++ b/server/tests/replay.c
@@ -221,7 +221,6 @@  static void end_replay(void)
         kill(client_pid, SIGINT);
         waitpid(client_pid, &child_status, 0);
     }
-    exit(0);
 }
 
 static void release_resource(QXLInstance *qin, struct QXLReleaseInfoExt release_info)
@@ -440,6 +439,7 @@  int main(int argc, char **argv)
     if (print_count)
         g_print("Counted %d commands\n", ncommands);
 
+    spice_server_destroy(server);
     end_replay();
     g_async_queue_unref(display_queue);
     g_async_queue_unref(cursor_queue);

Comments

looks like it's already acked by Pavel, but

Acked-by: Jonathon Jongsma <jjongsma@redhat.com>


On Mon, 2016-12-05 at 12:16 +0000, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
> Acked-by: Pavel Grunt <pgrunt@redhat.com>
> ---
>  server/tests/replay.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/server/tests/replay.c b/server/tests/replay.c
> index f32fa2f..23d4125 100644
> --- a/server/tests/replay.c
> +++ b/server/tests/replay.c
> @@ -221,7 +221,6 @@ static void end_replay(void)
>          kill(client_pid, SIGINT);
>          waitpid(client_pid, &child_status, 0);
>      }
> -    exit(0);
>  }
>  
>  static void release_resource(QXLInstance *qin, struct
> QXLReleaseInfoExt release_info)
> @@ -440,6 +439,7 @@ int main(int argc, char **argv)
>      if (print_count)
>          g_print("Counted %d commands\n", ncommands);
>  
> +    spice_server_destroy(server);
>      end_replay();
>      g_async_queue_unref(display_queue);
>      g_async_queue_unref(cursor_queue);