[Spice-devel,spice-server] dcc: Avoid to include RedChannelClient private header

Submitted by Frediano Ziglio on Dec. 2, 2016, 7:40 p.m.

Details

Message ID 20161202194018.18154-1-fziglio@redhat.com
State Accepted
Commit c6e816309322fb3d69731928414e8159e0ad9c5e
Headers show
Series "dcc: Avoid to include RedChannelClient private header" ( rev: 1 ) in Spice

Not browsing as part of any series.

Commit Message

Frediano Ziglio Dec. 2, 2016, 7:40 p.m.
Make sure we don't tamper with RedChannelClient internals.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
---
 server/dcc.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Patch hide | download patch | download mbox

diff --git a/server/dcc.c b/server/dcc.c
index cf5f44c..afe37b1 100644
--- a/server/dcc.c
+++ b/server/dcc.c
@@ -22,7 +22,6 @@ 
 #include "dcc-private.h"
 #include "display-channel.h"
 #include "display-channel-private.h"
-#include "red-channel-client-private.h"
 #include "red-client.h"
 #include "main-channel-client.h"
 #include "spice-server-enums.h"
@@ -222,7 +221,7 @@  int dcc_clear_surface_drawables_from_pipe(DisplayChannelClient *dcc, int surface
        no other drawable depends on them */
 
     rcc = RED_CHANNEL_CLIENT(dcc);
-    for (l = rcc->priv->pipe.head; l != NULL; ) {
+    for (l = red_channel_client_get_pipe(rcc)->head; l != NULL; ) {
         Drawable *drawable;
         RedDrawablePipeItem *dpi = NULL;
         int depend_found = FALSE;

Comments

Acked-by: Jonathon Jongsma <jjongsma@redhat.com>


On Fri, 2016-12-02 at 19:40 +0000, Frediano Ziglio wrote:
> Make sure we don't tamper with RedChannelClient internals.
> 
> Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
> ---
>  server/dcc.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/server/dcc.c b/server/dcc.c
> index cf5f44c..afe37b1 100644
> --- a/server/dcc.c
> +++ b/server/dcc.c
> @@ -22,7 +22,6 @@
>  #include "dcc-private.h"
>  #include "display-channel.h"
>  #include "display-channel-private.h"
> -#include "red-channel-client-private.h"
>  #include "red-client.h"
>  #include "main-channel-client.h"
>  #include "spice-server-enums.h"
> @@ -222,7 +221,7 @@ int
> dcc_clear_surface_drawables_from_pipe(DisplayChannelClient *dcc, int
> surface
>         no other drawable depends on them */
>  
>      rcc = RED_CHANNEL_CLIENT(dcc);
> -    for (l = rcc->priv->pipe.head; l != NULL; ) {
> +    for (l = red_channel_client_get_pipe(rcc)->head; l != NULL; ) {
>          Drawable *drawable;
>          RedDrawablePipeItem *dpi = NULL;
>          int depend_found = FALSE;