[Spice-devel,client,v2,2/3] spicy: Temporarily ignore deprecation warnings

Submitted by Christophe Fergeau on Dec. 1, 2016, 12:24 p.m.

Details

Message ID 20161201122423.fn4cl76ftxlumv2n@edamame.cdg.redhat.com
State New
Headers show
Series "Deprecation warning cleanup" ( rev: 11 10 ) in Spice

Not browsing as part of any series.

Commit Message

Christophe Fergeau Dec. 1, 2016, 12:24 p.m.
I think I'd handle this one similarly to the vala warnings:


On Wed, Nov 23, 2016 at 07:09:20AM +0100, Francois Gouget wrote:
> GtkAction and lots of GtkUI APIs are deprecated.
> 
> Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
> ---
>  src/spicy.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/spicy.c b/src/spicy.c
> index c502428..c4a6c7d 100644
> --- a/src/spicy.c
> +++ b/src/spicy.c
> @@ -38,6 +38,9 @@
>  
>  #include "spicy-connect.h"
>  
> +/* FIXME: GtkAction and lots of GtkUI APIs are deprecated */
> +G_GNUC_BEGIN_IGNORE_DEPRECATIONS
> +
>  typedef struct spice_connection spice_connection;
>  
>  enum {
> -- 
> 2.10.1
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel

Patch hide | download patch | download mbox

diff --git a/src/Makefile.am b/src/Makefile.am
index 3f81866..66e3c64 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -402,10 +402,12 @@  spicy_LDADD =                                             \
        $(LIBM)                                         \
        $(NULL)

+# FIXME: GtkAction and lots of GtkUI APIs are deprecated
 spicy_CPPFLAGS =                       \
        $(AM_CPPFLAGS)                  \
        $(GTHREAD_CFLAGS)               \
        -DSPICE_DISABLE_DEPRECATED      \
+       -Wno-deprecated-declarations    \
        $(NULL)



Comments

On Thu, 1 Dec 2016, Christophe Fergeau wrote:

> I think I'd handle this one similarly to the vala warnings:
> 
> diff --git a/src/Makefile.am b/src/Makefile.am
> index 3f81866..66e3c64 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -402,10 +402,12 @@ spicy_LDADD =                                             \
>         $(LIBM)                                         \
>         $(NULL)
> 
> +# FIXME: GtkAction and lots of GtkUI APIs are deprecated
>  spicy_CPPFLAGS =                       \
>         $(AM_CPPFLAGS)                  \
>         $(GTHREAD_CFLAGS)               \
>         -DSPICE_DISABLE_DEPRECATED      \
> +       -Wno-deprecated-declarations    \
>         $(NULL)

Acked-by: Francois Gouget <fgouget@codeweavers.com>

Makes sense.
I'll let you commit and push the patch.