[Spice-devel,spice-server,v4,2/4] gstreamer: Do not warn for tested formats

Submitted by Frediano Ziglio on Nov. 28, 2016, 12:05 p.m.

Details

Message ID 20161128120505.14925-3-fziglio@redhat.com
State Accepted
Headers show
Series "Gstreamer testing" ( rev: 2 ) in Spice

Not browsing as part of any series.

Commit Message

Frediano Ziglio Nov. 28, 2016, 12:05 p.m.
These formats were tested manually using test-gst utility
in server/tests.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
---
 server/gstreamer-encoder.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/server/gstreamer-encoder.c b/server/gstreamer-encoder.c
index b9b1a56..e6406f6 100644
--- a/server/gstreamer-encoder.c
+++ b/server/gstreamer-encoder.c
@@ -759,7 +759,7 @@  static const SpiceFormatForGStreamer format_map[] =  {
     {SPICE_BITMAP_FMT_INVALID, "", 0, 0, 0, 0, 0, 0},
     {SPICE_BITMAP_FMT_RGBA, "BGRA", 32, 24, 4321, 0xff000000, 0xff0000, 0xff00},
     {SPICE_BITMAP_FMT_16BIT, "RGB15", 16, 15, 4321, 0x001f, 0x03E0, 0x7C00},
-    /* TODO: Test the other formats */
+    /* TODO: Test the other formats under GStreamer 0.10*/
     {SPICE_BITMAP_FMT_32BIT, "BGRx", 32, 24, 4321, 0xff000000, 0xff0000, 0xff00},
     {SPICE_BITMAP_FMT_24BIT, "BGR", 24, 24, 4321, 0xff0000, 0xff00, 0xff},
 };
@@ -771,9 +771,11 @@  static const SpiceFormatForGStreamer *map_format(SpiceBitmapFmt format)
     int i;
     for (i = 0; i < G_N_ELEMENTS(format_map); i++) {
         if (format_map[i].spice_format == format) {
+#ifdef HAVE_GSTREAMER_0_10
             if (i > 2) {
                 spice_warning("The %d format has not been tested yet", format);
             }
+#endif
             return &format_map[i];
         }
     }