[Spice-devel,spice-server,17/20] cursor: Avoid cursor item leak

Submitted by Frediano Ziglio on Nov. 24, 2016, 5:39 p.m.

Details

Message ID 20161124173907.3341-18-fziglio@redhat.com
State Accepted
Commit cd57ce246cc15e8e206e1e5dd40ff7a8df2482f0
Headers show
Series "Start cleaning objects on destruction" ( rev: 1 ) in Spice

Not browsing as part of any series.

Commit Message

Frediano Ziglio Nov. 24, 2016, 5:39 p.m.
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
---
 server/cursor-channel.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

Patch hide | download patch | download mbox

diff --git a/server/cursor-channel.c b/server/cursor-channel.c
index 202ec89..e421bf7 100644
--- a/server/cursor-channel.c
+++ b/server/cursor-channel.c
@@ -438,10 +438,25 @@  void cursor_channel_connect(CursorChannel *cursor, RedClient *client, RedsStream
 }
 
 static void
+cursor_channel_finalize(GObject *object)
+{
+    CursorChannel *self = CURSOR_CHANNEL(object);
+
+    if (self->item) {
+        cursor_item_unref(self->item);
+    }
+
+    G_OBJECT_CLASS(cursor_channel_parent_class)->finalize(object);
+}
+
+static void
 cursor_channel_class_init(CursorChannelClass *klass)
 {
+    GObjectClass *object_class = G_OBJECT_CLASS(klass);
     RedChannelClass *channel_class = RED_CHANNEL_CLASS(klass);
 
+    object_class->finalize = cursor_channel_finalize;
+
     channel_class->parser = spice_get_client_channel_parser(SPICE_CHANNEL_CURSOR, NULL);
     channel_class->handle_parsed = red_channel_client_handle_message;