[Spice-devel,client,v2,3/3] build-sys: Enable deprecation warnings instead of ignoring them entirely

Submitted by Francois Gouget on Nov. 23, 2016, 6:09 a.m.

Details

Message ID aeac79573a2f21aa57aeef7bc29a513305bd763f.1479880294.git.fgouget@free.fr
State New
Headers show
Series "Deprecation warning cleanup" ( rev: 7 ) in Spice

Not browsing as part of any series.

Commit Message

Francois Gouget Nov. 23, 2016, 6:09 a.m.
For Spice-gtk most deprecation issues come from changes outside Spice
(GLib) and thus should not be treated as errors to not break
compilation for users who have newer third-party libraries.
However they must be visible otherwise Spice developers will not be
aware of them and thus will not fix them before breakage happens.

Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
---
 m4/spice-compile-warnings.m4 | 2 +-
 src/controller/Makefile.am   | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/m4/spice-compile-warnings.m4 b/m4/spice-compile-warnings.m4
index 533bac6..dfa88fe 100644
--- a/m4/spice-compile-warnings.m4
+++ b/m4/spice-compile-warnings.m4
@@ -85,7 +85,7 @@  AC_DEFUN([SPICE_COMPILE_WARNINGS],[
     gl_WARN_ADD([-Wno-format-nonliteral])
     # We use some deprecated functions to avoid #ifdef hell while maintaining
     # compat with older gtk / glib versions
-    gl_WARN_ADD([-Wno-deprecated-declarations])
+    gl_WARN_ADD([-Wno-error=deprecated-declarations])
 
 
 
diff --git a/src/controller/Makefile.am b/src/controller/Makefile.am
index fb56986..c68373c 100644
--- a/src/controller/Makefile.am
+++ b/src/controller/Makefile.am
@@ -1,5 +1,7 @@ 
 NULL =
 
+# FIXME: We need to disable the deprecation warnings until valac stops
+#        generating code that uses the deprecated GSimpleAsyncResult class.
 AM_CPPFLAGS =					\
 	-DG_LOG_DOMAIN=\"GSpiceController\"	\
 	$(GIO_CFLAGS)				\

Comments

On Wed, Nov 23, 2016 at 07:09:28AM +0100, Francois Gouget wrote:
> For Spice-gtk most deprecation issues come from changes outside Spice
> (GLib) and thus should not be treated as errors to not break
> compilation for users who have newer third-party libraries.
> However they must be visible otherwise Spice developers will not be
> aware of them and thus will not fix them before breakage happens.

Also iirc -DXXX_VERSION_MIN_REQUIRED=yyy need deprecation warnings to be
functional

Christophe