[v2,1/2] drm/amd/powerplay: fix firmware loading failure

Submitted by Yu, Xiangliang on Nov. 22, 2016, 3:02 a.m.

Details

Message ID 1479783725-4184-1-git-send-email-Xiangliang.Yu@amd.com
State New
Headers show
Series "Series without cover letter" ( rev: 1 ) in AMD X.Org drivers

Not browsing as part of any series.

Commit Message

Yu, Xiangliang Nov. 22, 2016, 3:02 a.m.
For virtualization, firmware loading need the firmware version info,
and will load the right firmware. So, transfer fw_version to toc.

v2: use "drm/amd/powerplay" as the prefix for patch title.

Signed-off-by: Xiangliang Yu <Xiangliang.Yu@amd.com>
---
 drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c
index 6df0d6e..c9bd1cf 100644
--- a/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c
+++ b/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c
@@ -366,7 +366,7 @@  static int smu7_populate_single_firmware_entry(struct pp_smumgr *smumgr,
 				&info);
 
 	if (!result) {
-		entry->version = info.version;
+		entry->version = info.fw_version;
 		entry->id = (uint16_t)fw_type;
 		entry->image_addr_high = smu_upper_32_bits(info.mc_addr);
 		entry->image_addr_low = smu_lower_32_bits(info.mc_addr);

Comments

> -----Original Message-----

> From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On Behalf

> Of Xiangliang Yu

> Sent: Monday, November 21, 2016 10:02 PM

> To: amd-gfx@freedesktop.org

> Cc: Yu, Xiangliang

> Subject: [Patch v2 1/2] drm/amd/powerplay: fix firmware loading failure

> 

> For virtualization, firmware loading need the firmware version info,

> and will load the right firmware. So, transfer fw_version to toc.

> 

> v2: use "drm/amd/powerplay" as the prefix for patch title.

> 

> Signed-off-by: Xiangliang Yu <Xiangliang.Yu@amd.com>


Reviewed-by: Alex Deucher <alexander.deucher@amd.com>


> ---

>  drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c

> b/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c

> index 6df0d6e..c9bd1cf 100644

> --- a/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c

> +++ b/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c

> @@ -366,7 +366,7 @@ static int

> smu7_populate_single_firmware_entry(struct pp_smumgr *smumgr,

>  				&info);

> 

>  	if (!result) {

> -		entry->version = info.version;

> +		entry->version = info.fw_version;

>  		entry->id = (uint16_t)fw_type;

>  		entry->image_addr_high =

> smu_upper_32_bits(info.mc_addr);

>  		entry->image_addr_low =

> smu_lower_32_bits(info.mc_addr);

> --

> 2.7.4

> 

> _______________________________________________

> amd-gfx mailing list

> amd-gfx@lists.freedesktop.org

> https://lists.freedesktop.org/mailman/listinfo/amd-gfx