acpi: video: Move ACPI_VIDEO_NOTIFY_* defines to acpi/video.h

Submitted by Hans de Goede on Nov. 9, 2016, 5:15 p.m.

Details

Message ID 20161109171556.4003-1-hdegoede@redhat.com
State New
Headers show
Series "acpi: video: Move ACPI_VIDEO_NOTIFY_* defines to acpi/video.h" ( rev: 1 ) in Nouveau

Not browsing as part of any series.

Commit Message

Hans de Goede Nov. 9, 2016, 5:15 p.m.
acpi_video.c passed the ACPI_VIDEO_NOTIFY_* defines as type code to
acpi_notifier_call_chain(). Move these defines to acpi/video.h so
that acpi_notifier listeners can check the type code using these
defines.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/acpi/acpi_video.c | 11 -----------
 include/acpi/video.h      | 11 +++++++++++
 2 files changed, 11 insertions(+), 11 deletions(-)

Patch hide | download patch | download mbox

diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi/acpi_video.c
index c5557d0..201292e 100644
--- a/drivers/acpi/acpi_video.c
+++ b/drivers/acpi/acpi_video.c
@@ -43,17 +43,6 @@ 
 
 #define ACPI_VIDEO_BUS_NAME		"Video Bus"
 #define ACPI_VIDEO_DEVICE_NAME		"Video Device"
-#define ACPI_VIDEO_NOTIFY_SWITCH	0x80
-#define ACPI_VIDEO_NOTIFY_PROBE		0x81
-#define ACPI_VIDEO_NOTIFY_CYCLE		0x82
-#define ACPI_VIDEO_NOTIFY_NEXT_OUTPUT	0x83
-#define ACPI_VIDEO_NOTIFY_PREV_OUTPUT	0x84
-
-#define ACPI_VIDEO_NOTIFY_CYCLE_BRIGHTNESS	0x85
-#define	ACPI_VIDEO_NOTIFY_INC_BRIGHTNESS	0x86
-#define ACPI_VIDEO_NOTIFY_DEC_BRIGHTNESS	0x87
-#define ACPI_VIDEO_NOTIFY_ZERO_BRIGHTNESS	0x88
-#define ACPI_VIDEO_NOTIFY_DISPLAY_OFF		0x89
 
 #define MAX_NAME_LEN	20
 
diff --git a/include/acpi/video.h b/include/acpi/video.h
index 4536bd3..bfe484d 100644
--- a/include/acpi/video.h
+++ b/include/acpi/video.h
@@ -30,6 +30,17 @@  struct acpi_device;
 #define ACPI_VIDEO_DISPLAY_LEGACY_PANEL   0x0110
 #define ACPI_VIDEO_DISPLAY_LEGACY_TV      0x0200
 
+#define ACPI_VIDEO_NOTIFY_SWITCH		0x80
+#define ACPI_VIDEO_NOTIFY_PROBE			0x81
+#define ACPI_VIDEO_NOTIFY_CYCLE			0x82
+#define ACPI_VIDEO_NOTIFY_NEXT_OUTPUT		0x83
+#define ACPI_VIDEO_NOTIFY_PREV_OUTPUT		0x84
+#define ACPI_VIDEO_NOTIFY_CYCLE_BRIGHTNESS	0x85
+#define ACPI_VIDEO_NOTIFY_INC_BRIGHTNESS	0x86
+#define ACPI_VIDEO_NOTIFY_DEC_BRIGHTNESS	0x87
+#define ACPI_VIDEO_NOTIFY_ZERO_BRIGHTNESS	0x88
+#define ACPI_VIDEO_NOTIFY_DISPLAY_OFF		0x89
+
 enum acpi_backlight_type {
 	acpi_backlight_undef = -1,
 	acpi_backlight_none = 0,

Comments

On Wed, Nov 09, 2016 at 06:15:56PM +0100, Hans de Goede wrote:
> acpi_video.c passed the ACPI_VIDEO_NOTIFY_* defines as type code to
> acpi_notifier_call_chain(). Move these defines to acpi/video.h so
> that acpi_notifier listeners can check the type code using these
> defines.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Reviewed-by: Peter Wu <peter@lekensteyn.nl>

> ---
>  drivers/acpi/acpi_video.c | 11 -----------
>  include/acpi/video.h      | 11 +++++++++++
>  2 files changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi/acpi_video.c
> index c5557d0..201292e 100644
> --- a/drivers/acpi/acpi_video.c
> +++ b/drivers/acpi/acpi_video.c
> @@ -43,17 +43,6 @@
>  
>  #define ACPI_VIDEO_BUS_NAME		"Video Bus"
>  #define ACPI_VIDEO_DEVICE_NAME		"Video Device"
> -#define ACPI_VIDEO_NOTIFY_SWITCH	0x80
> -#define ACPI_VIDEO_NOTIFY_PROBE		0x81
> -#define ACPI_VIDEO_NOTIFY_CYCLE		0x82
> -#define ACPI_VIDEO_NOTIFY_NEXT_OUTPUT	0x83
> -#define ACPI_VIDEO_NOTIFY_PREV_OUTPUT	0x84
> -
> -#define ACPI_VIDEO_NOTIFY_CYCLE_BRIGHTNESS	0x85
> -#define	ACPI_VIDEO_NOTIFY_INC_BRIGHTNESS	0x86
> -#define ACPI_VIDEO_NOTIFY_DEC_BRIGHTNESS	0x87
> -#define ACPI_VIDEO_NOTIFY_ZERO_BRIGHTNESS	0x88
> -#define ACPI_VIDEO_NOTIFY_DISPLAY_OFF		0x89
>  
>  #define MAX_NAME_LEN	20
>  
> diff --git a/include/acpi/video.h b/include/acpi/video.h
> index 4536bd3..bfe484d 100644
> --- a/include/acpi/video.h
> +++ b/include/acpi/video.h
> @@ -30,6 +30,17 @@ struct acpi_device;
>  #define ACPI_VIDEO_DISPLAY_LEGACY_PANEL   0x0110
>  #define ACPI_VIDEO_DISPLAY_LEGACY_TV      0x0200
>  
> +#define ACPI_VIDEO_NOTIFY_SWITCH		0x80
> +#define ACPI_VIDEO_NOTIFY_PROBE			0x81
> +#define ACPI_VIDEO_NOTIFY_CYCLE			0x82
> +#define ACPI_VIDEO_NOTIFY_NEXT_OUTPUT		0x83
> +#define ACPI_VIDEO_NOTIFY_PREV_OUTPUT		0x84
> +#define ACPI_VIDEO_NOTIFY_CYCLE_BRIGHTNESS	0x85
> +#define ACPI_VIDEO_NOTIFY_INC_BRIGHTNESS	0x86
> +#define ACPI_VIDEO_NOTIFY_DEC_BRIGHTNESS	0x87
> +#define ACPI_VIDEO_NOTIFY_ZERO_BRIGHTNESS	0x88
> +#define ACPI_VIDEO_NOTIFY_DISPLAY_OFF		0x89
> +
>  enum acpi_backlight_type {
>  	acpi_backlight_undef = -1,
>  	acpi_backlight_none = 0,
> -- 
> 2.9.3
>
On Wednesday, November 09, 2016 06:15:56 PM Hans de Goede wrote:
> acpi_video.c passed the ACPI_VIDEO_NOTIFY_* defines as type code to
> acpi_notifier_call_chain(). Move these defines to acpi/video.h so
> that acpi_notifier listeners can check the type code using these
> defines.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

I've applied this one, but I'd like to get an ACK from the DRM folks on
the second one.

Thanks,
Rafael
On 11/24/2016 11:27 AM, Rafael J. Wysocki wrote:
> On Wednesday, November 09, 2016 06:15:56 PM Hans de Goede wrote:
>> acpi_video.c passed the ACPI_VIDEO_NOTIFY_* defines as type code to
>> acpi_notifier_call_chain(). Move these defines to acpi/video.h so
>> that acpi_notifier listeners can check the type code using these
>> defines.
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> 
> I've applied this one, but I'd like to get an ACK from the DRM folks on
> the second one.
I've already taken the Nouveau patch through my tree.

Ben.
> 
> Thanks,
> Rafael
>