[Spice-devel,client,v2,02/10] spicy: Avoid gtk_vbox_new(); it is deprecated

Submitted by Francois Gouget on Oct. 19, 2016, 4:06 p.m.

Details

Message ID d0009c5f9dcf6139e68006a3d2f5a13daa3db913.1476892275.git.fgouget@free.fr
State New
Headers show
Series "Deprecation warning cleanup" ( rev: 4 3 2 ) in Spice

Not browsing as part of any series.

Commit Message

Francois Gouget Oct. 19, 2016, 4:06 p.m.
Spice-Gtk requires GTK+ > 3.12 which has gtk_box_new().

Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
---
 src/spicy-connect.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Patch hide | download patch | download mbox

diff --git a/src/spicy-connect.c b/src/spicy-connect.c
index c471df5..a1d895a 100644
--- a/src/spicy-connect.c
+++ b/src/spicy-connect.c
@@ -156,7 +156,7 @@  gboolean spicy_connect_dialog(SpiceSession *session)
     gtk_window_set_resizable(window, FALSE);
     gtk_container_set_border_width(GTK_CONTAINER(window), 5);
 
-    main_box = GTK_BOX(gtk_vbox_new(FALSE, 0));
+    main_box = GTK_BOX(gtk_box_new(GTK_ORIENTATION_VERTICAL, 0));
     gtk_container_add(GTK_CONTAINER(window), GTK_WIDGET(main_box));
 
     table = GTK_TABLE(gtk_table_new(3, 2, 0));
@@ -181,7 +181,7 @@  gboolean spicy_connect_dialog(SpiceSession *session)
         }
     }
 
-    recent_box = GTK_BOX(gtk_vbox_new(FALSE, 0));
+    recent_box = GTK_BOX(gtk_box_new(GTK_ORIENTATION_VERTICAL, 0));
     gtk_box_pack_start(main_box, GTK_WIDGET(recent_box), TRUE, TRUE, 0);
     gtk_container_set_border_width(GTK_CONTAINER(recent_box), 5);
 

Comments

Acked-by: Jonathon Jongsma <jjongsma@redhat.com>


On Wed, 2016-10-19 at 18:06 +0200, Francois Gouget wrote:
> Spice-Gtk requires GTK+ > 3.12 which has gtk_box_new().
> 
> Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
> ---
>  src/spicy-connect.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/spicy-connect.c b/src/spicy-connect.c
> index c471df5..a1d895a 100644
> --- a/src/spicy-connect.c
> +++ b/src/spicy-connect.c
> @@ -156,7 +156,7 @@ gboolean spicy_connect_dialog(SpiceSession
> *session)
>      gtk_window_set_resizable(window, FALSE);
>      gtk_container_set_border_width(GTK_CONTAINER(window), 5);
>  
> -    main_box = GTK_BOX(gtk_vbox_new(FALSE, 0));
> +    main_box = GTK_BOX(gtk_box_new(GTK_ORIENTATION_VERTICAL, 0));
>      gtk_container_add(GTK_CONTAINER(window), GTK_WIDGET(main_box));
>  
>      table = GTK_TABLE(gtk_table_new(3, 2, 0));
> @@ -181,7 +181,7 @@ gboolean spicy_connect_dialog(SpiceSession
> *session)
>          }
>      }
>  
> -    recent_box = GTK_BOX(gtk_vbox_new(FALSE, 0));
> +    recent_box = GTK_BOX(gtk_box_new(GTK_ORIENTATION_VERTICAL, 0));
>      gtk_box_pack_start(main_box, GTK_WIDGET(recent_box), TRUE, TRUE,
> 0);
>      gtk_container_set_border_width(GTK_CONTAINER(recent_box), 5);
>