[Spice-devel] spice-widget-x11: fix typo, add a missing comma (, )

Submitted by Uri Lublin on July 30, 2012, 3:48 p.m.

Details

Message ID f8e3d72b6400484daf1627d702dae52029fa88ab.1343663246.git.uril@redhat.com
State New
Headers show

Not browsing as part of any series.

Commit Message

Uri Lublin July 30, 2012, 3:48 p.m.
Found-by: Nicolas Prochazka <prochazka.nicolas@gmail.com>
---
 gtk/spice-widget-x11.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Patch hide | download patch | download mbox

diff --git a/gtk/spice-widget-x11.c b/gtk/spice-widget-x11.c
index 7fc99ff..12865ba 100644
--- a/gtk/spice-widget-x11.c
+++ b/gtk/spice-widget-x11.c
@@ -236,7 +236,7 @@  void spicex_expose_event(SpiceDisplay *display, GdkEventExpose *expose)
             XPutImage(d->dpy, gdk_x11_drawable_get_xid(window),
                       d->gc, d->ximage,
                       d->area.x + expose->area.x - d->mx, d->area.y + expose->area.y - d->my,
-                      expose->area.x expose->area.y,
+                      expose->area.x, expose->area.y,
                       expose->area.width, expose->area.height);
         }
     } else {

Comments

ACK,

Note I believe it is fine to push such trivial fixes without a patch.

On 07/30/2012 05:48 PM, Uri Lublin wrote:
> Found-by: Nicolas Prochazka <prochazka.nicolas@gmail.com>
> ---
>   gtk/spice-widget-x11.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/gtk/spice-widget-x11.c b/gtk/spice-widget-x11.c
> index 7fc99ff..12865ba 100644
> --- a/gtk/spice-widget-x11.c
> +++ b/gtk/spice-widget-x11.c
> @@ -236,7 +236,7 @@ void spicex_expose_event(SpiceDisplay *display, GdkEventExpose *expose)
>               XPutImage(d->dpy, gdk_x11_drawable_get_xid(window),
>                         d->gc, d->ximage,
>                         d->area.x + expose->area.x - d->mx, d->area.y + expose->area.y - d->my,
> -                      expose->area.x expose->area.y,
> +                      expose->area.x, expose->area.y,
>                         expose->area.width, expose->area.height);
>           }
>       } else {
>
hello,
this patch seems to be not apply in master git spice-gtk branch

Regards,
Nicolas Prochazka

2012/7/30 Uri Lublin <uril@redhat.com>

> Found-by: Nicolas Prochazka <prochazka.nicolas@gmail.com>
> ---
>  gtk/spice-widget-x11.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/gtk/spice-widget-x11.c b/gtk/spice-widget-x11.c
> index 7fc99ff..12865ba 100644
> --- a/gtk/spice-widget-x11.c
> +++ b/gtk/spice-widget-x11.c
> @@ -236,7 +236,7 @@ void spicex_expose_event(SpiceDisplay *display,
> GdkEventExpose *expose)
>              XPutImage(d->dpy, gdk_x11_drawable_get_xid(window),
>                        d->gc, d->ximage,
>                        d->area.x + expose->area.x - d->mx, d->area.y +
> expose->area.y - d->my,
> -                      expose->area.x expose->area.y,
> +                      expose->area.x, expose->area.y,
>                        expose->area.width, expose->area.height);
>          }
>      } else {
> --
> 1.7.1
>
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
>
On 08/30/2012 04:07 PM, nicolas prochazka wrote:
> hello,
> this patch seems to be not apply in master git spice-gtk branch

Hello Nicolas,

It is already committed in master branch of spice-gtk git.

Regards,
     Uri,
hi,
it seems that's
http://cgit.freedesktop.org/spice/spice-gtk/commit/gtk/spice-widget-x11.c?id=e3bb7b1cfd162fcb8943e9d582dab43eeec6ce41
(commit e3bb7b1cfd162fcb8943e9d582dab43eeec6ce41<http://cgit.freedesktop.org/spice/spice-gtk/commit/gtk/spice-widget-x11.c?id=e3bb7b1cfd162fcb8943e9d582dab43eeec6ce41>
)
reintroduce it
and d0bc4f9194c0b8d6a001883344ab2689ea13c6b4<http://cgit.freedesktop.org/spice/spice-gtk/commit/gtk/spice-widget-x11.c?id=d0bc4f9194c0b8d6a001883344ab2689ea13c6b4>
corrige
it again ? ( 08.30.2012)

so it's ok
Regards,
Nicolas



2012/9/2 Uri Lublin <uril@redhat.com>

> On 08/30/2012 04:07 PM, nicolas prochazka wrote:
>
>> hello,
>> this patch seems to be not apply in master git spice-gtk branch
>>
>
> Hello Nicolas,
>
> It is already committed in master branch of spice-gtk git.
>
> Regards,
>     Uri,
>