[4/8] drm/amdgpu: remove 128 NOP hack from vm_flush

Submitted by Christian König on Oct. 5, 2016, 2:13 p.m.

Details

Message ID 1475676809-3061-4-git-send-email-deathsimple@vodafone.de
State New
Headers show
Series "Series without cover letter" ( rev: 1 ) in AMD X.Org drivers

Not browsing as part of any series.

Commit Message

Christian König Oct. 5, 2016, 2:13 p.m.
From: Christian König <christian.koenig@amd.com>

With the padding raised to 256 DW that shouldn't be needed any more.

Signed-off-by: Christian König <christian.koenig@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 4 ----
 1 file changed, 4 deletions(-)

Patch hide | download patch | download mbox

diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
index 8efd7db..90bb451 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
@@ -6253,10 +6253,6 @@  static void gfx_v8_0_ring_emit_vm_flush(struct amdgpu_ring *ring,
 {
 	int usepfp = (ring->type == AMDGPU_RING_TYPE_GFX);
 
-	/* GFX8 emits 128 dw nop to prevent DE do vm_flush before CE finish CEIB */
-	if (usepfp)
-		amdgpu_ring_insert_nop(ring, 128);
-
 	amdgpu_ring_write(ring, PACKET3(PACKET3_WRITE_DATA, 3));
 	amdgpu_ring_write(ring, (WRITE_DATA_ENGINE_SEL(usepfp) |
 				 WRITE_DATA_DST_SEL(0)) |

Comments

> -----Original Message-----

> From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On Behalf

> Of Christian König

> Sent: Wednesday, October 05, 2016 10:13 AM

> To: amd-gfx@lists.freedesktop.org

> Subject: [PATCH 4/8] drm/amdgpu: remove 128 NOP hack from vm_flush

> 

> From: Christian König <christian.koenig@amd.com>

> 

> With the padding raised to 256 DW that shouldn't be needed any more.

> 

> Signed-off-by: Christian König <christian.koenig@amd.com>

> ---

>  drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 4 ----

>  1 file changed, 4 deletions(-)

> 

> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c

> b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c

> index 8efd7db..90bb451 100644

> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c

> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c

> @@ -6253,10 +6253,6 @@ static void gfx_v8_0_ring_emit_vm_flush(struct

> amdgpu_ring *ring,

>  {

>  	int usepfp = (ring->type == AMDGPU_RING_TYPE_GFX);

> 

> -	/* GFX8 emits 128 dw nop to prevent DE do vm_flush before CE

> finish CEIB */

> -	if (usepfp)

> -		amdgpu_ring_insert_nop(ring, 128);

> -


Make sure to adjust the dma frame size as well in this patch.  With that fixed,
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>


Alex

>  	amdgpu_ring_write(ring, PACKET3(PACKET3_WRITE_DATA, 3));

>  	amdgpu_ring_write(ring, (WRITE_DATA_ENGINE_SEL(usepfp) |

>  				 WRITE_DATA_DST_SEL(0)) |

> --

> 2.5.0

> 

> _______________________________________________

> amd-gfx mailing list

> amd-gfx@lists.freedesktop.org

> https://lists.freedesktop.org/mailman/listinfo/amd-gfx