[Spice-devel,spice-common] python_modules/ptypes.py/EnumBaseType.c_enumname: add missing return to fix broken enums generation

Submitted by Alon Levy on June 14, 2012, 8:43 a.m.

Details

Message ID 1339663414-10959-1-git-send-email-alevy@redhat.com
State Accepted
Commit a976c16cf3f77c38d9006c3d39c96d6c8aa04110
Headers show

Not browsing as part of any series.

Commit Message

Alon Levy June 14, 2012, 8:43 a.m.
---
 python_modules/ptypes.py |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/python_modules/ptypes.py b/python_modules/ptypes.py
index 132ba99..d9fbfe2 100644
--- a/python_modules/ptypes.py
+++ b/python_modules/ptypes.py
@@ -234,7 +234,7 @@  class EnumBaseType(Type):
         return codegen.prefix_camel(self.name)
 
     def c_enumname(self, value):
-        self.c_enumname_by_name(self.names[value])
+        return self.c_enumname_by_name(self.names[value])
 
     def c_enumname_by_name(self, name):
         if self.has_attr("prefix"):

Comments

I don't see exactly what it will fixed, perhaps you should include a small example. But that looks like a typo and can't harm, ACK

----- Mensaje original -----
> ---
>  python_modules/ptypes.py |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/python_modules/ptypes.py b/python_modules/ptypes.py
> index 132ba99..d9fbfe2 100644
> --- a/python_modules/ptypes.py
> +++ b/python_modules/ptypes.py
> @@ -234,7 +234,7 @@ class EnumBaseType(Type):
>          return codegen.prefix_camel(self.name)
>  
>      def c_enumname(self, value):
> -        self.c_enumname_by_name(self.names[value])
> +        return self.c_enumname_by_name(self.names[value])
>  
>      def c_enumname_by_name(self, name):
>          if self.has_attr("prefix"):
> --
> 1.7.10.1
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
>
On Thu, Jun 14, 2012 at 05:11:02AM -0400, Marc-André Lureau wrote:
> I don't see exactly what it will fixed, perhaps you should include a small example. But that looks like a typo and can't harm, ACK
> 

./spice_codegen.py --generate-enums spice.proto spice-protocol/spice/enums.h

Produces a file with many "None"'s without this patch.

I'll update the commit message.

> ----- Mensaje original -----
> > ---
> >  python_modules/ptypes.py |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/python_modules/ptypes.py b/python_modules/ptypes.py
> > index 132ba99..d9fbfe2 100644
> > --- a/python_modules/ptypes.py
> > +++ b/python_modules/ptypes.py
> > @@ -234,7 +234,7 @@ class EnumBaseType(Type):
> >          return codegen.prefix_camel(self.name)
> >  
> >      def c_enumname(self, value):
> > -        self.c_enumname_by_name(self.names[value])
> > +        return self.c_enumname_by_name(self.names[value])
> >  
> >      def c_enumname_by_name(self, name):
> >          if self.has_attr("prefix"):
> > --
> > 1.7.10.1
> > 
> > _______________________________________________
> > Spice-devel mailing list
> > Spice-devel@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/spice-devel
> >