[Spice-devel,v2,2/2] Release 0.11.0

Submitted by Alon Levy on June 12, 2012, 11:53 a.m.

Details

Message ID 1339501982-19634-2-git-send-email-alevy@redhat.com
State New
Headers show

Not browsing as part of any series.

Commit Message

Alon Levy June 12, 2012, 11:53 a.m.
Current bumped and age bumped. Current bumped twice since previous
values (current = 1, age = 2) were illegal - age must be smaller or
equal to current, since it's interpreted as meaning our library supports
t interfaces [current, current - age].

New libtool version is thus 3.0.3, since there are added interfaces:

    spice_server_set_name;
    spice_server_set_uuid;
    spice_server_set_listen_socket_fd;
    spice_server_is_server_mouse;
---
 NEWS         |   33 +++++++++++++++++++++++++++++++++
 configure.ac |    8 ++++----
 2 files changed, 37 insertions(+), 4 deletions(-)

Patch hide | download patch | download mbox

diff --git a/NEWS b/NEWS
index 2deba57..68369af 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,36 @@ 
+Major changes in 0.11.0:
+========================
+* !Development Release!
+* 8817549..d905a1f
+* now using git submodules: spice-common and spice-protocol.
+* New spice protocol messages: (changes in spice-protocol, here for reference)
+ * SPICE_MSG_MAIN_NAME, SPICE_MSG_MAIN_UUID
+ * SPICE_MSG_DISPLAY_STREAM_DATA_SIZED
+* New corresponding caps: (changes in spice-protocol, here for reference)
+ * SPICE_MAIN_CAP_NAME_AND_UUID
+ * SPICE_DISPLAY_CAP_SIZED_STREAM.
+* Send name & uuid to capable clients
+* add support for frames of different sizes RHBZ #813826
+* server:
+ * support a pre-opened file descriptor
+ * Solaris support. Now using poll instead of epoll.
+ * Support IPV6 addresses in channel events RHBZ #788444
+ * other fixed RHBZ#: 787669, 787678, 819484
+* spicec
+ * alsa: use "default" instead of "hw:0,0"
+ * volume keys support RHBZ #552539
+ * other fixed RHBZ#: 78655, 804561, 641828
+* solaris, mingw & windows, 32 bit fixes.
+* enable server only build.
+* GNULIB manywarnings.m4 & warnings.m4 module added.
+* Many more bug fixes & code cleanups.
+* spice-protocol no longer external.
+* new server functions:
+ + spice_server_set_name
+ + spice_server_set_uuid
+ + spice_server_set_listen_socket_fd
+ + spice_server_is_server_mouse
+
 Major changes in 0.10.1:
 ========================
 * Mini header support
diff --git a/configure.ac b/configure.ac
index abe9092..0f5309e 100644
--- a/configure.ac
+++ b/configure.ac
@@ -10,8 +10,8 @@  AC_PREREQ([2.57])
 # *additionally* follow the rules below for the libtool version.
 
 m4_define([SPICE_MAJOR], 0)
-m4_define([SPICE_MINOR], 10)
-m4_define([SPICE_MICRO], 1)
+m4_define([SPICE_MINOR], 11)
+m4_define([SPICE_MICRO], 0)
 # See info libtool or http://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html
 # Here are the 6 rules: (rule 1 here just to avoid saying what I omitted)
 
@@ -34,9 +34,9 @@  m4_define([SPICE_MICRO], 1)
 # 6. If any interfaces have been removed or changed since the last
 #    public release, then set AGE to 0.
 
-m4_define([SPICE_CURRENT], [1])
+m4_define([SPICE_CURRENT], [3])
 m4_define([SPICE_REVISION], [0])
-m4_define([SPICE_AGE], [2])
+m4_define([SPICE_AGE], [3])
 
 AC_INIT(spice, [SPICE_MAJOR.SPICE_MINOR.SPICE_MICRO], [], spice)
 

Comments

On Tue, Jun 12, 2012 at 02:53:02PM +0300, Alon Levy wrote:
> Current bumped and age bumped. Current bumped twice since previous
> values (current = 1, age = 2) were illegal - age must be smaller or
> equal to current, since it's interpreted as meaning our library supports
> t interfaces [current, current - age].
> 
> New libtool version is thus 3.0.3, since there are added interfaces:
> 
>     spice_server_set_name;
>     spice_server_set_uuid;
>     spice_server_set_listen_socket_fd;
>     spice_server_is_server_mouse;
> ---
>  NEWS         |   33 +++++++++++++++++++++++++++++++++
>  configure.ac |    8 ++++----
>  2 files changed, 37 insertions(+), 4 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index abe9092..0f5309e 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -10,8 +10,8 @@ AC_PREREQ([2.57])
>  # *additionally* follow the rules below for the libtool version.
>  
>  m4_define([SPICE_MAJOR], 0)
> -m4_define([SPICE_MINOR], 10)
> -m4_define([SPICE_MICRO], 1)
> +m4_define([SPICE_MINOR], 11)
> +m4_define([SPICE_MICRO], 0)
>  # See info libtool or http://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html
>  # Here are the 6 rules: (rule 1 here just to avoid saying what I omitted)
>  
> @@ -34,9 +34,9 @@ m4_define([SPICE_MICRO], 1)
>  # 6. If any interfaces have been removed or changed since the last
>  #    public release, then set AGE to 0.
>  
> -m4_define([SPICE_CURRENT], [1])
> +m4_define([SPICE_CURRENT], [3])
>  m4_define([SPICE_REVISION], [0])
> -m4_define([SPICE_AGE], [2])
> +m4_define([SPICE_AGE], [3])


Unless I'm mis-understanding, I still think this results in a change
in SONAME for libspice-server.  IIUC, soname number == AGE - CURRENT,
which was previously '1' and is now '0'

Regards,
Daniel
On Tue, 2012-06-12 at 13:01 +0100, Daniel P. Berrange wrote:
> On Tue, Jun 12, 2012 at 02:53:02PM +0300, Alon Levy wrote:
> > Current bumped and age bumped. Current bumped twice since previous
> > values (current = 1, age = 2) were illegal - age must be smaller or
> > equal to current, since it's interpreted as meaning our library supports
> > t interfaces [current, current - age].
> > 
> > New libtool version is thus 3.0.3, since there are added interfaces:
> > 
> >     spice_server_set_name;
> >     spice_server_set_uuid;
> >     spice_server_set_listen_socket_fd;
> >     spice_server_is_server_mouse;
> > ---
> >  NEWS         |   33 +++++++++++++++++++++++++++++++++
> >  configure.ac |    8 ++++----
> >  2 files changed, 37 insertions(+), 4 deletions(-)
> > 
> > diff --git a/configure.ac b/configure.ac
> > index abe9092..0f5309e 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -10,8 +10,8 @@ AC_PREREQ([2.57])
> >  # *additionally* follow the rules below for the libtool version.
> >  
> >  m4_define([SPICE_MAJOR], 0)
> > -m4_define([SPICE_MINOR], 10)
> > -m4_define([SPICE_MICRO], 1)
> > +m4_define([SPICE_MINOR], 11)
> > +m4_define([SPICE_MICRO], 0)
> >  # See info libtool or http://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html
> >  # Here are the 6 rules: (rule 1 here just to avoid saying what I omitted)
> >  
> > @@ -34,9 +34,9 @@ m4_define([SPICE_MICRO], 1)
> >  # 6. If any interfaces have been removed or changed since the last
> >  #    public release, then set AGE to 0.
> >  
> > -m4_define([SPICE_CURRENT], [1])
> > +m4_define([SPICE_CURRENT], [3])
> >  m4_define([SPICE_REVISION], [0])
> > -m4_define([SPICE_AGE], [2])
> > +m4_define([SPICE_AGE], [3])
> 
> 
> Unless I'm mis-understanding, I still think this results in a change
> in SONAME for libspice-server.  IIUC, soname number == AGE - CURRENT,
> which was previously '1' and is now '0'

Actually the resulting library name is .so.3.0.3, so even stranger (I
expected .0.0.3 as well). According to libtool's version definition age
should always be smaller or equal to current. Since we already broke
that, I guess we can keep breaking it in the same way, since obviously
it works fine in practice.. I'll just go ahead and shoot this commit in
the head and increment both current and age.

> 
> Regards,
> Daniel
----- Original Message -----
> On Tue, Jun 12, 2012 at 02:53:02PM +0300, Alon Levy wrote:
> > Current bumped and age bumped. Current bumped twice since previous
> > values (current = 1, age = 2) were illegal - age must be smaller or
> > equal to current, since it's interpreted as meaning our library
> > supports
> > t interfaces [current, current - age].
> > 
> > New libtool version is thus 3.0.3, since there are added
> > interfaces:
> > 
> >     spice_server_set_name;
> >     spice_server_set_uuid;
> >     spice_server_set_listen_socket_fd;
> >     spice_server_is_server_mouse;
> > ---
> >  NEWS         |   33 +++++++++++++++++++++++++++++++++
> >  configure.ac |    8 ++++----
> >  2 files changed, 37 insertions(+), 4 deletions(-)
> > 
> > diff --git a/configure.ac b/configure.ac
> > index abe9092..0f5309e 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -10,8 +10,8 @@ AC_PREREQ([2.57])
> >  # *additionally* follow the rules below for the libtool version.
> >  
> >  m4_define([SPICE_MAJOR], 0)
> > -m4_define([SPICE_MINOR], 10)
> > -m4_define([SPICE_MICRO], 1)
> > +m4_define([SPICE_MINOR], 11)
> > +m4_define([SPICE_MICRO], 0)
> >  # See info libtool or
> >  http://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html
> >  # Here are the 6 rules: (rule 1 here just to avoid saying what I
> >  omitted)
> >  
> > @@ -34,9 +34,9 @@ m4_define([SPICE_MICRO], 1)
> >  # 6. If any interfaces have been removed or changed since the last
> >  #    public release, then set AGE to 0.
> >  
> > -m4_define([SPICE_CURRENT], [1])
> > +m4_define([SPICE_CURRENT], [3])
> >  m4_define([SPICE_REVISION], [0])
> > -m4_define([SPICE_AGE], [2])
> > +m4_define([SPICE_AGE], [3])
> 
> 
> Unless I'm mis-understanding, I still think this results in a change
> in SONAME for libspice-server.  IIUC, soname number == AGE - CURRENT,
> which was previously '1' and is now '0'
> 

My mistake - I misread libtool. So the CURRENT is directly used as the first, i.e. major, version, and so like you say changing it changes the SONAME. So the libtool help is incorrect - current should only be incremented on an incompatible change.

I'll do a new revision, more like gtk+/libvirt:
 - only keep the three above variables
 - age = minor
 - revision = micro
 - current = 1 + major (to not break existing users)

> Regards,
> Daniel
> --
> |: http://berrange.com      -o-
> |   http://www.flickr.com/photos/dberrange/ :|
> |: http://libvirt.org              -o-
> |            http://virt-manager.org :|
> |: http://autobuild.org       -o-
> |        http://search.cpan.org/~danberr/ :|
> |: http://entangle-photo.org       -o-
> |      http://live.gnome.org/gtk-vnc :|
>
----- Original Message -----
> 
> 
> ----- Original Message -----
> > On Tue, Jun 12, 2012 at 02:53:02PM +0300, Alon Levy wrote:
> > > Current bumped and age bumped. Current bumped twice since
> > > previous
> > > values (current = 1, age = 2) were illegal - age must be smaller
> > > or
> > > equal to current, since it's interpreted as meaning our library
> > > supports
> > > t interfaces [current, current - age].
> > > 
> > > New libtool version is thus 3.0.3, since there are added
> > > interfaces:
> > > 
> > >     spice_server_set_name;
> > >     spice_server_set_uuid;
> > >     spice_server_set_listen_socket_fd;
> > >     spice_server_is_server_mouse;
> > > ---
> > >  NEWS         |   33 +++++++++++++++++++++++++++++++++
> > >  configure.ac |    8 ++++----
> > >  2 files changed, 37 insertions(+), 4 deletions(-)
> > > 
> > > diff --git a/configure.ac b/configure.ac
> > > index abe9092..0f5309e 100644
> > > --- a/configure.ac
> > > +++ b/configure.ac
> > > @@ -10,8 +10,8 @@ AC_PREREQ([2.57])
> > >  # *additionally* follow the rules below for the libtool version.
> > >  
> > >  m4_define([SPICE_MAJOR], 0)
> > > -m4_define([SPICE_MINOR], 10)
> > > -m4_define([SPICE_MICRO], 1)
> > > +m4_define([SPICE_MINOR], 11)
> > > +m4_define([SPICE_MICRO], 0)
> > >  # See info libtool or
> > >  http://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html
> > >  # Here are the 6 rules: (rule 1 here just to avoid saying what I
> > >  omitted)
> > >  
> > > @@ -34,9 +34,9 @@ m4_define([SPICE_MICRO], 1)
> > >  # 6. If any interfaces have been removed or changed since the
> > >  last
> > >  #    public release, then set AGE to 0.
> > >  
> > > -m4_define([SPICE_CURRENT], [1])
> > > +m4_define([SPICE_CURRENT], [3])
> > >  m4_define([SPICE_REVISION], [0])
> > > -m4_define([SPICE_AGE], [2])
> > > +m4_define([SPICE_AGE], [3])
> > 
> > 
> > Unless I'm mis-understanding, I still think this results in a
> > change
> > in SONAME for libspice-server.  IIUC, soname number == AGE -
> > CURRENT,
> > which was previously '1' and is now '0'
> > 
> 
> My mistake - I misread libtool. So the CURRENT is directly used as
> the first, i.e. major, version, and so like you say changing it
> changes the SONAME. So the libtool help is incorrect - current
> should only be incremented on an incompatible change.

A second mistake, this was a result of -version-name and not libtool help being incorrect. So SONAME is indeed current-age. New question: is libspice-server.so.1.3.0 ><= 1.0.2 ?

> 
> I'll do a new revision, more like gtk+/libvirt:
>  - only keep the three above variables
>  - age = minor
>  - revision = micro
>  - current = 1 + major (to not break existing users)
> 
> > Regards,
> > Daniel
> > --
> > |: http://berrange.com      -o-
> > |   http://www.flickr.com/photos/dberrange/ :|
> > |: http://libvirt.org              -o-
> > |            http://virt-manager.org :|
> > |: http://autobuild.org       -o-
> > |        http://search.cpan.org/~danberr/ :|
> > |: http://entangle-photo.org       -o-
> > |      http://live.gnome.org/gtk-vnc :|
> > 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
>
On Tue, Jun 12, 2012 at 08:52:19AM -0400, Alon Levy wrote:
> A second mistake, this was a result of -version-name and not libtool help
> being incorrect. So SONAME is indeed current-age. New question: is
> libspice-server.so.1.3.0 ><= 1.0.2 ?

It should, even though we probably don't care ;)

Christophe