| Message ID | 1276388589-25258-1-git-send-email-sarvatt@ubuntu.com |
|---|---|
| State | Accepted, archived |
| Commit | c65280ce8df4836bd7424a90482e8aa00ab6f447 |
| Headers | show |
diff --git a/include/protocol-versions.h b/include/protocol-versions.h index 97ef5da..c674465 100644 --- a/include/protocol-versions.h +++ b/include/protocol-versions.h @@ -73,7 +73,7 @@ /* Render */ #define SERVER_RENDER_MAJOR_VERSION 0 -#define SERVER_RENDER_MINOR_VERSION 10 +#define SERVER_RENDER_MINOR_VERSION 11 /* RandR Xinerama */ #define SERVER_RRXINERAMA_MAJOR_VERSION 1
Ping. any comments on this one? I have verified it correctly uses
minor version 11 now via protocol tracing with xtruss
With this patch:
RenderQueryVersion(client-major-version=0, client-minor-version=11) =
<unfinished>
... RenderQueryVersion(client-major-version=0,
client-minor-version=11) = {major-version=0, minor-version=11}
Without this patch:
RenderQueryVersion(client-major-version=0, client-minor-version=11) =
<unfinished>
... RenderQueryVersion(client-major-version=0,
client-minor-version=11) = {major-version=0, minor-version=10}
It looks like an oversight that it was defined to 0.10 when it was
split out to include/protocol-versions.h because it required
renderproto 0.11 before that.
http://patchwork.freedesktop.org/patch/1048/
Thanks,
Robert
On Sat, Jun 12, 2010 at 08:23:09PM -0400, Robert Hooker wrote: > Support for the blend mode operators was added in > 0ce42adbf4cff9e7f049d9fc79d588ece5936177 > and the requirement was bumped but when things were split off into > include/protocol-versions.h it defined it to 10. render uses > the lower of the client and server advertised versions so it's not > using the new blend mode operators. > > Signed-off-by: Robert Hooker <sarvatt@ubuntu.com> > --- > include/protocol-versions.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/include/protocol-versions.h b/include/protocol-versions.h > index 97ef5da..c674465 100644 > --- a/include/protocol-versions.h > +++ b/include/protocol-versions.h > @@ -73,7 +73,7 @@ > > /* Render */ > #define SERVER_RENDER_MAJOR_VERSION 0 > -#define SERVER_RENDER_MINOR_VERSION 10 > +#define SERVER_RENDER_MINOR_VERSION 11 > > /* RandR Xinerama */ > #define SERVER_RRXINERAMA_MAJOR_VERSION 1 > -- > 1.7.1 Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net> Cheers, Peter
On Mon, Jul 5, 2010 at 7:16 PM, Peter Hutterer <peter.hutterer@who-t.net> wrote: > On Sat, Jun 12, 2010 at 08:23:09PM -0400, Robert Hooker wrote: >> Support for the blend mode operators was added in >> 0ce42adbf4cff9e7f049d9fc79d588ece5936177 >> and the requirement was bumped but when things were split off into >> include/protocol-versions.h it defined it to 10. render uses >> the lower of the client and server advertised versions so it's not >> using the new blend mode operators. > > Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net> Those changes were released in xserver 1.7, apparently. This patch looks to me like a low-risk fix to a longstanding bug, so should it perhaps be applied to 1.9? Jamey
On Mon, 5 Jul 2010 23:44:17 -0700, Jamey Sharp <jamey@minilop.net> wrote: > Those changes were released in xserver 1.7, apparently. This patch > looks to me like a low-risk fix to a longstanding bug, so should it > perhaps be applied to 1.9? We may find some client bugs this way, but I think it's appropriate to have this in 1.9.
Support for the blend mode operators was added in 0ce42adbf4cff9e7f049d9fc79d588ece5936177 and the requirement was bumped but when things were split off into include/protocol-versions.h it defined it to 10. render uses the lower of the client and server advertised versions so it's not using the new blend mode operators. Signed-off-by: Robert Hooker <sarvatt@ubuntu.com> --- include/protocol-versions.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)