[Spice-devel,spice-xpi] SetSSLChannels: add ssmartcard, susbredir, stunnel

Submitted by Alon Levy on May 9, 2012, 9:08 a.m.

Details

Message ID 1336554518-16327-1-git-send-email-alevy@redhat.com
State New
Headers show

Not browsing as part of any series.

Commit Message

Alon Levy May 9, 2012, 9:08 a.m.
Adding some more channels to the RHEL 5 list. The longer winded story is
that ovirt-engine passes us those values because vdsm unconditionally
removes the first letter of every channel name in the secure channels
list (aka SSLChannels here). Instead of changing vdsm, and dealing with
multiple vdsm versions for each cluster, a huge PITA, let spice-xpi
parse some extra channel names.

RHBZ: 790416
---
 SpiceXPI/src/plugin/plugin.cpp |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/SpiceXPI/src/plugin/plugin.cpp b/SpiceXPI/src/plugin/plugin.cpp
index 906c985..b7f61ba 100644
--- a/SpiceXPI/src/plugin/plugin.cpp
+++ b/SpiceXPI/src/plugin/plugin.cpp
@@ -337,7 +337,8 @@  void nsPluginInstance::SetSSLChannels(const char *aSSLChannels)
      */
     const char* chan_names[] = {
         "smain", "sdisplay", "sinputs",
-        "scursor", "splayback", "srecord"
+        "scursor", "splayback", "srecord",
+        "susbredir", "ssmartcard", "stunnel"
     };
     const int nnames = sizeof(chan_names) / sizeof(chan_names[0]);
 

Comments

On 05/09/2012 12:08 PM, Alon Levy wrote:
> Adding some more channels to the RHEL 5 list. The longer winded story is
> that ovirt-engine passes us those values because vdsm unconditionally
> removes the first letter of every channel name in the secure channels
> list (aka SSLChannels here). Instead of changing vdsm, and dealing with
> multiple vdsm versions for each cluster, a huge PITA, let spice-xpi
> parse some extra channel names.
>
> RHBZ: 790416
> ---
>   SpiceXPI/src/plugin/plugin.cpp |    3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/SpiceXPI/src/plugin/plugin.cpp b/SpiceXPI/src/plugin/plugin.cpp
> index 906c985..b7f61ba 100644
> --- a/SpiceXPI/src/plugin/plugin.cpp
> +++ b/SpiceXPI/src/plugin/plugin.cpp
> @@ -337,7 +337,8 @@ void nsPluginInstance::SetSSLChannels(const char *aSSLChannels)
>        */
>       const char* chan_names[] = {
>           "smain", "sdisplay", "sinputs",
> -        "scursor", "splayback", "srecord"
> +        "scursor", "splayback", "srecord",
> +        "susbredir", "ssmartcard", "stunnel"
>       };
>       const int nnames = sizeof(chan_names) / sizeof(chan_names[0]);
>


Ack.

Note, we define here that the usbredir channel is called "usbredir".