[Spice-devel] server/reds: add "usbredir" to recognized channel names

Submitted by Alon Levy on May 7, 2012, 11:37 a.m.

Details

Message ID 1336390679-8772-1-git-send-email-alevy@redhat.com
State Accepted
Commit ce8e865cf1fcd7ee6ef2e6f8b33506df31e3345e
Headers show

Not browsing as part of any series.

Commit Message

Alon Levy May 7, 2012, 11:37 a.m.
RHBZ: 819484

Signed-off-by: Alon Levy <alevy@redhat.com>
---
 server/reds.c |    1 +
 1 file changed, 1 insertion(+)

Patch hide | download patch | download mbox

diff --git a/server/reds.c b/server/reds.c
index 1696fbc..26d6f89 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -3971,6 +3971,7 @@  SPICE_GNUC_VISIBLE int spice_server_set_channel_security(SpiceServer *s, const c
 #ifdef USE_SMARTCARD
         [ SPICE_CHANNEL_SMARTCARD] = "smartcard",
 #endif
+        [ SPICE_CHANNEL_USBREDIR ] = "usbredir",
     };
     int i;
 

Comments

On Mon, May 7, 2012 at 1:37 PM, Alon Levy <alevy@redhat.com> wrote:
> RHBZ: 819484
>
> Signed-off-by: Alon Levy <alevy@redhat.com>
> ---
>  server/reds.c |    1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/server/reds.c b/server/reds.c
> index 1696fbc..26d6f89 100644
> --- a/server/reds.c
> +++ b/server/reds.c
> @@ -3971,6 +3971,7 @@ SPICE_GNUC_VISIBLE int spice_server_set_channel_security(SpiceServer *s, const c
>  #ifdef USE_SMARTCARD
>         [ SPICE_CHANNEL_SMARTCARD] = "smartcard",
>  #endif
> +        [ SPICE_CHANNEL_USBREDIR ] = "usbredir",
>     };
>     int i;

Why do we have a ifdef for smartcard but not for usbredir?

Otherwise looks trivial, ack.
On Mon, May 07, 2012 at 02:19:43PM +0200, Marc-André Lureau wrote:
> On Mon, May 7, 2012 at 1:37 PM, Alon Levy <alevy@redhat.com> wrote:
> > RHBZ: 819484
> >
> > Signed-off-by: Alon Levy <alevy@redhat.com>
> > ---
> >  server/reds.c |    1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/server/reds.c b/server/reds.c
> > index 1696fbc..26d6f89 100644
> > --- a/server/reds.c
> > +++ b/server/reds.c
> > @@ -3971,6 +3971,7 @@ SPICE_GNUC_VISIBLE int spice_server_set_channel_security(SpiceServer *s, const c
> >  #ifdef USE_SMARTCARD
> >         [ SPICE_CHANNEL_SMARTCARD] = "smartcard",
> >  #endif
> > +        [ SPICE_CHANNEL_USBREDIR ] = "usbredir",
> >     };
> >     int i;
> 
> Why do we have a ifdef for smartcard but not for usbredir?
> 
> Otherwise looks trivial, ack.

I don't think we compile out usbredir in any case, since it doesn't add
any requirements.

> 
> 
> -- 
> Marc-André Lureau