[Spice-devel] Change xorg-macros -> xorg-x11-util-macros in configure error message

Submitted by Yaniv Kaul on April 24, 2012, 10:22 a.m.

Details

Message ID 4F967EF1.9010202@redhat.com
State New
Headers show

Not browsing as part of any series.

Commit Message

Yaniv Kaul April 24, 2012, 10:22 a.m.
At least in Fedora 17, the correct RPM name is xorg-x11-util-macros

  XORG_DEFAULT_OPTIONS

Patch hide | download patch | download mbox

diff --git a/configure.ac b/configure.ac
index cb874f7..a97f477 100644
--- a/configure.ac
+++ b/configure.ac
@@ -36,7 +36,7 @@  AC_CONFIG_HEADERS([config.h])

  # Require xorg-macros: XORG_DEFAULT_OPTIONS
  m4_ifndef([XORG_MACROS_VERSION],
-          [m4_fatal([must install xorg-macros 1.4 or later before 
running autoconf/autogen])])
+          [m4_fatal([must install xorg-x11-util-macros 1.4 or later 
before running autoconf/autogen])])
  XORG_MACROS_VERSION(1.4)

Comments

That's for xf86-video-qxl .
Y.

On 04/24/2012 01:22 PM, Yaniv Kaul wrote:
> At least in Fedora 17, the correct RPM name is xorg-x11-util-macros
>
> diff --git a/configure.ac b/configure.ac
> index cb874f7..a97f477 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -36,7 +36,7 @@ AC_CONFIG_HEADERS([config.h])
>
>  # Require xorg-macros: XORG_DEFAULT_OPTIONS
>  m4_ifndef([XORG_MACROS_VERSION],
> -          [m4_fatal([must install xorg-macros 1.4 or later before 
> running autoconf/autogen])])
> +          [m4_fatal([must install xorg-x11-util-macros 1.4 or later 
> before running autoconf/autogen])])
>  XORG_MACROS_VERSION(1.4)
>  XORG_DEFAULT_OPTIONS
On Tue, Apr 24, 2012 at 01:22:41PM +0300, Yaniv Kaul wrote:
> At least in Fedora 17, the correct RPM name is xorg-x11-util-macros
> 

We could use the upstream name too, xorg-util-macros (kinda):
 http://cgit.freedesktop.org/xorg/util/macros/tree/configure.ac#n25

But this is better anyway.

ACK.


> diff --git a/configure.ac b/configure.ac
> index cb874f7..a97f477 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -36,7 +36,7 @@ AC_CONFIG_HEADERS([config.h])
> 
>  # Require xorg-macros: XORG_DEFAULT_OPTIONS
>  m4_ifndef([XORG_MACROS_VERSION],
> -          [m4_fatal([must install xorg-macros 1.4 or later before running
> autoconf/autogen])])
> +          [m4_fatal([must install xorg-x11-util-macros 1.4 or later before
> running autoconf/autogen])])
>  XORG_MACROS_VERSION(1.4)
>  XORG_DEFAULT_OPTIONS
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
On Tue, Apr 24, 2012 at 02:28:42PM +0300, Alon Levy wrote:
> On Tue, Apr 24, 2012 at 01:22:41PM +0300, Yaniv Kaul wrote:
> > At least in Fedora 17, the correct RPM name is xorg-x11-util-macros
> > 
> 
> We could use the upstream name too, xorg-util-macros (kinda):
>  http://cgit.freedesktop.org/xorg/util/macros/tree/configure.ac#n25
> 
> But this is better anyway.
> 
> ACK.

How does that help on a Debian or openSUSE system?

Christophe
> 
> 
> > diff --git a/configure.ac b/configure.ac
> > index cb874f7..a97f477 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -36,7 +36,7 @@ AC_CONFIG_HEADERS([config.h])
> > 
> >  # Require xorg-macros: XORG_DEFAULT_OPTIONS
> >  m4_ifndef([XORG_MACROS_VERSION],
> > -          [m4_fatal([must install xorg-macros 1.4 or later before running
> > autoconf/autogen])])
> > +          [m4_fatal([must install xorg-x11-util-macros 1.4 or later before
> > running autoconf/autogen])])
> >  XORG_MACROS_VERSION(1.4)
> >  XORG_DEFAULT_OPTIONS
> > _______________________________________________
> > Spice-devel mailing list
> > Spice-devel@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/spice-devel
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
On 04/24/2012 07:30 PM, Christophe Fergeau wrote:
> On Tue, Apr 24, 2012 at 02:28:42PM +0300, Alon Levy wrote:
>> On Tue, Apr 24, 2012 at 01:22:41PM +0300, Yaniv Kaul wrote:
>>> At least in Fedora 17, the correct RPM name is xorg-x11-util-macros
>>>
>> We could use the upstream name too, xorg-util-macros (kinda):
>>   http://cgit.freedesktop.org/xorg/util/macros/tree/configure.ac#n25
>>
>> But this is better anyway.
>>
>> ACK.
> How does that help on a Debian or openSUSE system?
>
> Christophe

It does not harm them in any way, AFAIK - I could not find similar named 
packages in either. So better get the name right on one distribution 
than none.
Y.

>>
>>> diff --git a/configure.ac b/configure.ac
>>> index cb874f7..a97f477 100644
>>> --- a/configure.ac
>>> +++ b/configure.ac
>>> @@ -36,7 +36,7 @@ AC_CONFIG_HEADERS([config.h])
>>>
>>>   # Require xorg-macros: XORG_DEFAULT_OPTIONS
>>>   m4_ifndef([XORG_MACROS_VERSION],
>>> -          [m4_fatal([must install xorg-macros 1.4 or later before running
>>> autoconf/autogen])])
>>> +          [m4_fatal([must install xorg-x11-util-macros 1.4 or later before
>>> running autoconf/autogen])])
>>>   XORG_MACROS_VERSION(1.4)
>>>   XORG_DEFAULT_OPTIONS
>>> _______________________________________________
>>> Spice-devel mailing list
>>> Spice-devel@lists.freedesktop.org
>>> http://lists.freedesktop.org/mailman/listinfo/spice-devel
>> _______________________________________________
>> Spice-devel mailing list
>> Spice-devel@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/spice-devel
On Tue, Apr 24, 2012 at 01:22:41PM +0300, Yaniv Kaul wrote:
> At least in Fedora 17, the correct RPM name is xorg-x11-util-macros
> 

Please fix your emailer to not split lines, it causes a malformed patch
- see the '-' and '+' lines below, there should not be an extra EOL
  between them.

> diff --git a/configure.ac b/configure.ac
> index cb874f7..a97f477 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -36,7 +36,7 @@ AC_CONFIG_HEADERS([config.h])
> 
>  # Require xorg-macros: XORG_DEFAULT_OPTIONS
>  m4_ifndef([XORG_MACROS_VERSION],
> -          [m4_fatal([must install xorg-macros 1.4 or later before running
> autoconf/autogen])])
> +          [m4_fatal([must install xorg-x11-util-macros 1.4 or later before
> running autoconf/autogen])])
>  XORG_MACROS_VERSION(1.4)
>  XORG_DEFAULT_OPTIONS
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
On Wed, Apr 25, 2012 at 03:15:00PM +0300, Alon Levy wrote:
> On Tue, Apr 24, 2012 at 01:22:41PM +0300, Yaniv Kaul wrote:
> > At least in Fedora 17, the correct RPM name is xorg-x11-util-macros
> > 
> 
> Please fix your emailer to not split lines, it causes a malformed patch
> - see the '-' and '+' lines below, there should not be an extra EOL
>   between them.

Better still, use   git send-email for all patches, so that
all commit metadata is included, not solely the diff

Daniel
On Wed, Apr 25, 2012 at 01:21:45PM +0100, Daniel P. Berrange wrote:
> On Wed, Apr 25, 2012 at 03:15:00PM +0300, Alon Levy wrote:
> > On Tue, Apr 24, 2012 at 01:22:41PM +0300, Yaniv Kaul wrote:
> > > At least in Fedora 17, the correct RPM name is xorg-x11-util-macros
> > > 
> > 
> > Please fix your emailer to not split lines, it causes a malformed patch
> > - see the '-' and '+' lines below, there should not be an extra EOL
> >   between them.
> 
> Better still, use   git send-email for all patches, so that
> all commit metadata is included, not solely the diff

+1

Note that I'll push this patch already, since it's trivial to fix, but
just note for the next time.

> 
> Daniel
> -- 
> |: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
> |: http://libvirt.org              -o-             http://virt-manager.org :|
> |: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
> |: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
On Wed, Apr 25, 2012 at 12:59:46PM +0300, Yaniv Kaul wrote:
> It does not harm them in any way, AFAIK - I could not find similar
> named packages in either. So better get the name right on one
> distribution than none.

I'd rather we use the name of the upstream tarball to say something like
"install upstream-name or the corresponding distro package before running
autoconf/autogen" rather than going with a "oh that's the info *I* need so
it will be good enough for everyone on earth"

Christophe
On Wed, Apr 25, 2012 at 03:05:55PM +0200, Christophe Fergeau wrote:
> On Wed, Apr 25, 2012 at 12:59:46PM +0300, Yaniv Kaul wrote:
> > It does not harm them in any way, AFAIK - I could not find similar
> > named packages in either. So better get the name right on one
> > distribution than none.
> 
> I'd rather we use the name of the upstream tarball to say something like
> "install upstream-name or the corresponding distro package before running
> autoconf/autogen" rather than going with a "oh that's the info *I* need so
> it will be good enough for everyone on earth"

The wording before the patch didn't correspond to the upstream as well,
so it was a little confusing. But feel welcome to send a patch for this
and I'll ack it.

> 
> Christophe



> _______________________________________________
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel