Patchwork [dummy,2/2] Add XORG_LIBS to LIBADD

login
register
mail settings
Submitter Yaakov Selkowitz
Date March 28, 2012, 5:16 a.m.
Message ID <1332911790-6464-5-git-send-email-yselkowitz@users.sourceforge.net>
Download mbox | patch
Permalink /patch/9657/
State Accepted
Commit a78d524cfb332909dba89df5d709081515f0ed36
Headers show

Comments

Yaakov Selkowitz - March 28, 2012, 5:16 a.m.
From: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>

This affects only Cygwin, where drivers must be linked against the
Xorg implib.  On other systems, XORG_LIBS will be empty.

Signed-off-by: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
---
 src/Makefile.am |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Alan Coopersmith - March 29, 2012, 3:25 a.m.
On 03/27/12 10:16 PM, Yaakov (Cygwin/X) wrote:
> From: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
> 
> This affects only Cygwin, where drivers must be linked against the
> Xorg implib.  On other systems, XORG_LIBS will be empty.
> 
> Signed-off-by: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
> ---
>  src/Makefile.am |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/src/Makefile.am b/src/Makefile.am
> index 52b9921..4bc9242 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -29,6 +29,7 @@ AM_CFLAGS = $(XORG_CFLAGS) $(PCIACCESS_CFLAGS)
>  
>  dummy_drv_la_LTLIBRARIES = dummy_drv.la
>  dummy_drv_la_LDFLAGS = -module -avoid-version
> +dummy_drv_la_LIBADD = $(XORG_LIBS)
>  dummy_drv_ladir = @moduledir@/drivers
>  
>  dummy_drv_la_SOURCES = \

Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Patch

diff --git a/src/Makefile.am b/src/Makefile.am
index 52b9921..4bc9242 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -29,6 +29,7 @@  AM_CFLAGS = $(XORG_CFLAGS) $(PCIACCESS_CFLAGS)
 
 dummy_drv_la_LTLIBRARIES = dummy_drv.la
 dummy_drv_la_LDFLAGS = -module -avoid-version
+dummy_drv_la_LIBADD = $(XORG_LIBS)
 dummy_drv_ladir = @moduledir@/drivers
 
 dummy_drv_la_SOURCES = \